1701356 - OpenPGP key selection lost when opening key properties

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Andreas]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36 Edg/89.0.774.63

Steps to reproduce:

Have a personal key selected as your encryption key in the account settings tab. Open the key properties through the account settings tab (not the OpenPGP key manager). Close the key properties.

Actual results:

The selection of the key is lost when closing the key properties. Thunderbird won't use the key for encryption. Actually, no option is selected. When closing and reopening the account settings tab, encryption is set to "Do not use OpenPGP for this identity".

Expected results:

Keep the key selection when opening the key properties.

Comment 1

[Magnus Melin [:mkmelin]]

Confirmed.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1701356 - make sure to stop event propagation in key selection so that events below the radios do not unselect. r=aleca

OpenPGP key selection was lost when opening key propertie, or any of the "More" actions.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f4d5fe69b5f1
make sure to stop event propagation in key selection so that events below the radios do not unselect. r=aleca

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9216713 [details]
Bug 1701356 - make sure to stop event propagation in key selection so that events below the radios do not unselect. r=aleca

[Approval Request Comment]
Safe fix to avoid confusing UI.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9216713 [details]
Bug 1701356 - make sure to stop event propagation in key selection so that events below the radios do not unselect. r=aleca

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 89.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/6ccdbaca7c22

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9216713 [details]
Bug 1701356 - make sure to stop event propagation in key selection so that events below the radios do not unselect. r=aleca

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.10.2:
https://hg.mozilla.org/releases/comm-esr78/rev/0608f355e5be