1701379 - Fullscreen/pointer lock warning has wrong stack order

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Matt Hensman]

Attachment: example.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Trigger fullscreen or pointer lock with the active browser tab or notification bar overlapping the warning overlay.

Actual results:

The warning overlay that appears when entering fullscreen or pointer lock is positioned behind the active browser tab bar tab element and any visible notification bars.

Expected results:

Warning overlay should appear in front of all other UI elements?

Comment 1

[Matt Hensman]

Attachment: example2.png

Comment 2

[Matt Hensman]

Attachment: example1.png

Comment 3

[Marcela (Please NI request to Brindusa Tot)]

I was able to reproduce this issue on latest Nightly version 89.0a1 (2021-03-29) (64-bit) on Windows 10 64-bit.
I'll set a component and change flags accordingly. If this is not the right component please feel free to route this ticket to the corresponding team, thanks!
The severity suggested is S3

Comment 4

[John Dai[:jdai]]

Edgar is probably more familiar with the issue here.

Comment 5

[Edgar Chen [:edgar]]

Seems like a regression of changing notification bar styles, bug 1656494, jaws, mind taking a look? Thanks.

Comment 6

[Punam Dahiya [:pdahiya]]

NI @ciprian to help provide the regression range, thanks

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1701379 - Set z-index on the pointerlock warning to place it higher than the notification and tabs.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be2240af9b8d
Set z-index on the pointerlock warning to place it higher than the notification and tabs. r=desktop-theme-reviewers,dao

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/be2240af9b8d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta uplift?

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9213614 [details]
Bug 1701379 - Set z-index on the pointerlock warning to place it higher than the notification and tabs.

Beta/Release Uplift Approval Request

• User impact if declined: Pointer lock message unable to be read if notification bar is visible
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS change
• String changes made/needed: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9213614 [details]
Bug 1701379 - Set z-index on the pointerlock warning to place it higher than the notification and tabs.

Approved for 88.0rc1, thanks.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5bcec6e51a16

Comment 16

[Petruta Horea [:phorea]]

Verified as fixed using latest Nightly 89.0a1 2021-04-12 under Win 10 64-bit and Mac OSX 11.2.3.
I will follow-up with 88RC verification once the build will be available.

Comment 17

[Petruta Horea [:phorea]]

Verified fixed on Firefox 88.0RC on Win 10 64-bit and Mac OSX 11.2.3.