[wayland] Incorrect anchor hints in NativeMoveResizeWaylandPopup for hamburger menu
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
People
(Reporter: rmader, Unassigned)
References
(Blocks 1 open bug)
Details
Some drive-by observations while looking into bug 1645695: we appear to get or calculate wrong anchor hints for menus like the hamburger menu.
Comparing with what we do on X11, we probably want something like GDK_ANCHOR_FLIP_Y | GDK_ANCHOR_RESIZE_Y | GDK_ANCHOR_SLIDE_X, however we always set GDK_ANCHOR_SLIDE because IsMainMenuWindow() is actually false for the hamburger menu. This can cause the menu to slide in both directions, completely losing connection to the anchor point - the non-Wayland FF code seems to allow sliding only on one axis, while usually flipping on the other.
Further more we do not appear to adapt the menu "arrow" to point to the anchor, it always remains on the top-right.
|
||
Comment 1•5 years ago
|
||
Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.
|
|
||
Comment 2•5 years ago
|
||
Please re-test with new nightly as it gets another popup fixes.
Thanks.
|
|
||
Comment 3•4 years ago
|
||
Robert, is that still a problem? Hamburger menu is placed as expected when I move Firefox window to various screen corners.
|
Reporter | |
Comment 4•4 years ago
|
||
I haven't verified in the code and the positioning is still different than on X11 - but it looks very reasonable :) Closing for now.
Description
•