Closed Bug 1701516 Opened 4 years ago Closed 2 years ago

[wpt-sync] Sync PR 28269 - CSSColorValue Typed OM

Categories

(Core :: DOM: CSS Object Model, task, P4)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28269 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28269
Details from upstream follow.

b'Aaron Krajeski <aaronhk@chromium.org>' wrote:

CSSColorValue Typed OM

From this spec:
https://drafts.css-houdini.org/css-typed-om-1/#colorvalue-objects

Unfortunately I had to rename the existing CSSColorValue class, found
in third_party/blink/renderer/core/css/css_color_value.h to CSSColor in
order to avoid a naming collision. It would be a bad idea to have two
similar classes with the same name regardless. The javascript object
(the one I'm creating here) is already spec'd to use the CSSColorValue
name. I could be convinced to do that in a separate CL to keep things
tidy.

Implemented the CSSRGB subclass only.

Bug: 1193099, 1187575
Change-Id: I3f09ca5d6f547e57df0ed7a94e276f5eb0a80451

Reviewed-on: https://chromium-review.googlesource.com/2788510
WPT-Export-Revision: 31990a9a9d182a7faabd790b4f44f5fa23b85cf2

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.