1701577 - Preferences - Applications focus ring truncated but top-header section in table

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot(1).png

Affected versions

• 88.0a1(2021-03-28)

Affected platforms

• Win10, Ubuntu 20;

Steps to reproduce

1. Launch Firefox, access about:preferences#general
2. Scroll down to the Applications section;
3. Click inside the Search File types or applications field;
4. Press the TAB key 2 times;

Expected result

• focus ring displayed properly;

Actual result

• focus ring appears truncated;

Regression range

• will check and provide one asap;

Additional notes

• reproducible with proton pref both on/off
• attached screenshot with the issue.

Comment 2

[:Gijs (he/him)]

Gah, executed the change on the wrong bug.

Comment 3

[:Gijs (he/him)]

I suspect this is caused by bug 1697863. Mike, can you take a look? Perhaps we just want to give the menulists position: relative and a z-index or something?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

I'll note that truncated focus rings have always been an issue in this part of the UI. This screenshot is from a Jan 1, 2021 Nightly.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1701577 - Make sure application menulist focus rings are not truncated. r?Itiel!

This seems to be better with or without Proton enabled.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b013163bb223
Make sure application menulist focus rings are not truncated. r=Itiel

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b013163bb223

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9212321 [details]
Bug 1701577 - Make sure application menulist focus rings are not truncated. r?Itiel!

Beta/Release Uplift Approval Request

• User impact if declined: A slightly truncated focus ring in the about:preferences applications list if the user is keyboard navigating.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a simple style-only change that only affects this particular part of the UI.
• String changes made/needed:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9212321 [details]
Bug 1701577 - Make sure application menulist focus rings are not truncated. r?Itiel!

Approved for 88.0b6.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/77f729997193

Comment 12

[Cristian Fogel [:cfogel]]

Verified the patch with 89.0a1 (2021-04-07), 88.0b8.

Comment 13

[Cristian Fogel [:cfogel]]

Attachment: fcus.gif

However, the Proton scheme makes it a bit hard to notice when the row is in focus.
Should we file a separate issue for it?

• awaiting on reply until updating flags.

Comment 14

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed on 89.0a1 (2021-04-11) and 88.0b9(20210408190318). Verified on macOS 10.15.7, Ubuntu 20.04 and Win10x64.