1701578 - Importing the generated metrics breaks depending on the Glean import order

Status: RESOLVED FIXED

(Data Platform and Tools Graveyard :: Glean.js, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

If Glean is imported before the generated metrics everything works fine, if after everything breaks due to "Metrics" not being defined.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean.js/pull/165

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: Part 2 - PR

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean.js/pull/184

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean.js/pull/192

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean.js/pull/198

Comment 6

[Alessio Placitelli [:Dexter]]

All the circular dependencies were taken care of. We need to test whether or not swapping the include order is now fixed.

Comment 7

[Alessio Placitelli [:Dexter]]

(In reply to Alessio Placitelli [:Dexter] from comment #6)

All the circular dependencies were taken care of. We need to test whether or not swapping the include order is now fixed.

I verified that this works by swapping these two imports. Without the changes in this bug, it fails with

https://github.com/mozilla/glean.js/blob/eb58d5d4b14cda20f297ae0182e84f217440a301/samples/web-extension/javascript/tests/unit/index.test.js#L6-L8

With the changes from this bug, the test runs fine:)