1701671 - DPI problems with mozregression on Win10

Status: NEW

(Testing :: mozregression, defect)

Description

[William Lachance (:wlach)]

Attachment: mozregression-gui.exe.manifest

According to some internal testing on the #moco channel, mozregression still looks weird in some high-resolution environments. :agashlin recommended adding a manifest file, which seemed to help.

Adding this to mozregression itself is more work than I can take on right now, but would accept a patch. This (oldish) stackoverflow question may or may not be relevant:

https://stackoverflow.com/questions/43823824/how-do-you-add-a-manifest-to-pyinstaller-compiled-exe

If it's possible to configure pyinstaller to use this manifest, you would probably want to edit this file: https://github.com/mozilla/mozregression/blob/master/gui/gui.spec

I'll also attach the suggested manifest that agashlin provided.

Comment 1

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

For clarification, pyinstaller already adds a manifest, the only line I added was <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>, as recommended in this Qt bug. I'm still not 100% sure why this is needed, the default should be DPI unaware, but it has the effect of taking mozregression out of "per-monitor DPI aware" mode and into the simpler "system DPI aware" mode, see Microsoft's High DPI documentation. This means that Windows is going to do some blurry scaling if the window isn't on the primary monitor (or if the DPI otherwise changes), but it should at least keep consistent text size.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.