1701688 - The line height of the “Import Error” modal is smaller than it should be

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: line height.png

[Affected Versions]:

• Firefox Beta 88.0b4 (Build ID: 20210328185936)
• Firefox Nightly 89.0a1 (Build ID: 20210329095128)

[Affected Platforms]:

• Linux Mint 20
• Windows 10
• macOS 10.15.7

[Prerequisites]:

• Have Firefox open.

[Steps to reproduce]:

1. Navigate to “about:logins”.
2. Click the meatball menu button (“...”).
3. Choose the “Import from a File...” option.
4. Choose a CSV file without a header and import it.
5. Observe the text of the “Import Error” modal.

[Expected result]:

• The font has a larger line height for the text inside it.

[Actual result]:

• The font seems to have a smaller line height for the text inside it compared to the documentation.

[Notes]:

• Attached is a screenshot of the issue compared to the documentation.

Comment 1

[Osagie]

Can I be assigned this bug please? Thanks Tim

Comment 2

[Tim Giles [:tgiles]]

Hi Osagie, I'll assign you the bug.

To help Mozilla out with this bug, here's the steps:

2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Developer Guide,
     which has answers to most development questions.
3. Start working on this bug.
   • You will need to add a line height rule for this import error dialog. Most likely you will need to add the missing style to the .content rule in browser/components/aboutlogins/import-error-dialog.css. This line-height will probably be 1.55, but I don't have an exact value so try to make it look like the screenshot in Comment #0
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #lockwise-desktop channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and test your change with
   mach test browser/components/aboutlogins/ --headless.
   Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 3

[Osagie]

Thank you Tim. I8 have looked at the bug and read your guidance. I'm on it and having a go!

Comment 4

[Maria Heres, inactive, contact Ecosystem QA]

The issues seems to have been fixed as part of Bug 1701690. Considering the space between rows now seems to be too large, Bug 1706320 has been filed. Tested using Firefox Nightly 90.0a1 (Build ID: 20210419221626) on Linux Mint 20, Windows 10, macOS 11.1.

Comment 5

[Maria Heres, inactive, contact Ecosystem QA]

@Tim Giles, considering my previous comment, do you think this issue can be closed?

Comment 6

[Tim Giles [:tgiles]]

:mheres, yeah I think we can go ahead and close this bug since it was fixed as part of Bug 1701690. Thanks for calling that out!

Comment 7

[Maria Heres, inactive, contact Ecosystem QA]

Considering the previous comments, I will mark this as verified fixed.