1701707 - Fix tabs-related tests that fail with browser.proton.enabled

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[:Gijs (he/him)]

Trypush after tabs graduated this past weekend:

https://treeherder.mozilla.org/jobs?repo=try&revision=426e797dd8ba07f53f7a8fa2c60f0df454713038&selectedTaskRun=Sv7DMvQVQAu_lQYBdXfYqw.0

There are several failing tests in browser/base/content/test/tabs/ , as well as browser/base/content/test/performance/ . Other failing tests:

browser/base/content/test/tabMediaIndicator/browser_mute_webAudio.js
toolkit/components/extensions/test/browser/browser_ext_themes_tab_separators.js
toolkit/content/tests/browser/browser_delay_autoplay_silentAudioTrack_media.js

Jared, can you take a look?

Comment 1

[:Gijs (he/him)]

(Note: trypush still going at time of writing so things not in comment #0 might crop up...)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1701707 - Fix browser_mute_webAudio.js by first hovering the tab-icon-stack before hovering the audio icon.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1701707 - Update the tab tooltip for audio regardless if Proton is enabled or not.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1701707 - Skip browser_ext_themes_tab_separators.js when Proton is enabled since the separators have been removed.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1701707 - Disable the shadow on the selected tab for browser_tabopen.js and account for internal tab padding.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1701707 - Remove padding changes to first and last tab since the padding is already applied on the scrollbox to prevent clipping of the shadow.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1701707 - Update browser_tabCloseSpacer.js to account for the close button changing size whether the tab is hovered or not.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0e80aaecc6a
Fix browser_mute_webAudio.js by first hovering the tab-icon-stack before hovering the audio icon. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/686173b570d9
Update the tab tooltip for audio regardless if Proton is enabled or not. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/8464cfabf176
Skip browser_ext_themes_tab_separators.js when Proton is enabled since the separators have been removed. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/1d11f6774014
Disable the shadow on the selected tab for browser_tabopen.js and account for internal tab padding. r=desktop-theme-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/18886ac707b6
Remove padding changes to first and last tab since the padding is already applied on the scrollbox to prevent clipping of the shadow. r=desktop-theme-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/89f7f47b16b3
Update browser_tabCloseSpacer.js to account for the close button changing size whether the tab is hovered or not. r=Gijs

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a0e80aaecc6a
https://hg.mozilla.org/mozilla-central/rev/686173b570d9
https://hg.mozilla.org/mozilla-central/rev/8464cfabf176
https://hg.mozilla.org/mozilla-central/rev/1d11f6774014
https://hg.mozilla.org/mozilla-central/rev/18886ac707b6
https://hg.mozilla.org/mozilla-central/rev/89f7f47b16b3