Closed Bug 1701723 Opened 3 years ago Closed 3 years ago

Downloads Panel shows focus ring around footer element when opening via mouse

Categories

(Firefox :: Downloads Panel, defect, P2)

Product:
Firefox
Component:
Downloads Panel
Platform:
Desktop
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- verified

People

(Reporter: mconley, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers][priority:2a])

Attachments

(2 files)

image.png
26.68 KB, image/png
Details
Bug 1701723, do not show focus ring on footer button when opening downloads panel
48 bytes, text/x-phabricator-request
Details | Review
Attached image image.png —

STR:

  1. Ensure browser.proton.enabled and browser.proton.doorhangers.enabled is set to true, and browser.download.autohideButton is set to false.
  2. Click on the Downloads Panel button in the toolbar

ER:

The panel opens without showing a focus ring around the footer element.

AR:

See screenshot.

I've so far only reproduced this on macOS.

Priority: -- → P2
Attachment #9212688 - Attachment description: Bug 1701723, do not focus footer button when opening downloads panel → WIP: Bug 1701723, do not focus footer button when opening downloads panel
Attachment #9212688 - Attachment description: WIP: Bug 1701723, do not focus footer button when opening downloads panel → Bug 1701723, do not focus footer button when opening downloads panel
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Whiteboard: [proton-door-hangers] → [proton-door-hangers][priority:2a]
Attachment #9212688 - Attachment description: Bug 1701723, do not focus footer button when opening downloads panel → Bug 1701723, do not show focus ring on footer button when opening downloads panel
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36a73e0e4afa
do not show focus ring on footer button when opening downloads panel r=mconley

https://hg.mozilla.org/mozilla-central/rev/36a73e0e4afa

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Flags: qe-verify+

Verified the fix using Firefox 89.0b3 on Windows 10 x64, Ubuntu 18.04 x32 and macOS 10.15. The issue is not reproducing anymore.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: