Closed Bug 1701742 Opened 4 years ago Closed 4 years ago

Make Chromium (Widevine) manifest codec parse failure non fatal

Categories

(Core :: Audio/Video: Playback, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: bryce, Assigned: bryce)

References

Details

Attachments

(1 file)

Bug 1701089 bit us with this. I suspect the original idea behind this was to help catch when the manifest changes. I suggest we instead debug assert when we don't recognize a string, which will help us catch manifest parse problems in dev, and cause less issues in release builds if Widevine change the manifest.

Summary: Make Chromium (Widevine) manifest parse failure non fatal → Make Chromium (Widevine) manifest codec parse failure non fatal

This has bitten us a couple of times. Instead of outright failing just skip
unrecognized strings in release. Assert in debug builds so we can still catch
this.

Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64b9a32ba7c9 Make Chromium/Widevine manifest codec parse failure non fatal. r=alwu
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: