1701756 - images for search bar setting in about:preferences are stretched

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Sören Hentzschel]

STR:

1. open the search settings

Expected:

The images for search bar settings in about:preferences looks good.

Actual:

The images for search bar settings in about:preferences are stretched. This is a regression from bug 1697003. Removing the "Show Firefox Suggest in the address bar (suggested and sponsored results)" row via Inspector fixes the images.

Comment 1

[Sören Hentzschel]

Attachment: screenshot

Comment 2

[Sören Hentzschel]

Attachment: expected look

Comment 3

[Drew Willcoxon :adw]

Bug 1697003 may have triggered this because it made the string longer, but the real regressing problem is adding the checkbox in the first place in bug 1693123.

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1701756 - Fix stretched navbar images in the search bar preferences UI.

We just need to set align=start on #searchBarVisibleGroup. There are a
couple of things to note about this:

• The images are stretched only when the Quick Suggest checkbox is visible,
  which it isn't unless the Quick Suggest pref is enabled
• This is broken even without the Quick Suggest checkbox because the two images
  shrink when the window is narrow

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5a265c2b2a5
Fix stretched navbar images in the search bar preferences UI. r=Gijs,preferences-reviewers

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a5a265c2b2a5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 9212952 [details]
Bug 1701756 - Fix stretched navbar images in the search bar preferences UI.

Beta/Release Uplift Approval Request

• User impact if declined: The only problem that will happen for users on 88 is that the navbar images in about:preferences#search shrink horizontally when the window is narrow. This goes back to at least 80, so it's not a new problem.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 0. In addition to that, also try making the window very narrow; the navbar images should not shrink, and instead all the text and images on about:preferences should simply overflow the window width and not be shrunk or squished.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch adds a single attribute to the search-related UI in about:preferences and any potential problems should be easy to spot -- and I don't see any. On the other hand, since the image-shrinking problem goes back to at least 80, and the other problem mentioned in comment 0 will not be encountered by users on 88, there's no urgent need to uplift this.
• String changes made/needed:

Comment 9

[Cornel Ionce [:noni]]

Attachment: Nightly89.jpg

I've looked over this using latest 89.0a1 Nightly build and noticed that the icons are still shrinking/getting squished when the window gets narrower.

Same results on Windows 10 x64, macOS 10.15 and Ubuntu 18.04.
Tested with both "en-US" and "de" locales.

Attaching a screenshot.

Comment 10

[Drew Willcoxon :adw]

You're right, thanks. I swear the patch fixed the shrinking problem when I first tested it, but now that I try again, I see it doesn't. I went back and tried an older base mozilla-central revision in case something else changed between the time I wrote the patch and the time I landed it, but no, the images shrink there too. I must have been testing with quick suggest enabled and not realized it. With it enabled, the images do not shrink.

Are you able to verify comment 0 is fixed at least? It is for me -- hopefully I'm right this time. :-)

Comment 11

[Drew Willcoxon :adw]

Comment on attachment 9212952 [details]
Bug 1701756 - Fix stretched navbar images in the search bar preferences UI.

There's no need to uplift this because it doesn't fix anything on 88 after all. The problem in comment 0 is due to quick suggest, and quick suggest is scheduled for 89.

Comment 12

[Sören Hentzschel]

Are you able to verify comment 0 is fixed at least? It is for me -- hopefully I'm right this time. :-)

Yes, the issue described in comment 0 is fixed. :-)

Comment 13

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue from comment 0 using old Nightly build from 2021-03-29 with pref browser.urlbar.quicksuggest.enabled enabled. Verified that the issues described in comment 0 and comment 9 are no longer reproducible using latest Firefox 89.0 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).