nsWindowDataSource leaks its RDF global variables, since its gRefCnt is never incremented. I'll attach one possible patch for fixing it, although if the object is guaranteed to have only one instance for the entire app, I don't see why these shouldn't just become member variables.
David Baron :dbaron: 🏴 ⌚UTC-8 (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)(Assignee)
16 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.2beta
Comment on attachment 100152 [details] [diff] [review] patch (simple approach) oops. sr=alecf
Attachment #100152 - Flags: superreview+
as for why they aren't member vars, I don't know. Its a pattern that we use all over the place in datasources so that we don't waste memory if there are multiple instances of the datasource.. though frankly datasources like this will really only have one instance.
Comment on attachment 100152 [details] [diff] [review] patch (simple approach) r=bryner
Attachment #100152 - Flags: review+
Fix checked in to trunk, 2002-09-23 20:20 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.