nsWindowDataSource leaks some RDF stuff

RESOLVED FIXED in mozilla1.2beta

Status

SeaMonkey
UI Design
P3
normal
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({memory-leak})

Trunk
mozilla1.2beta
x86
Linux
memory-leak

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch][tind-mlk])

Attachments

(1 attachment)

nsWindowDataSource leaks its RDF global variables, since its gRefCnt is never
incremented.  I'll attach one possible patch for fixing it, although if the
object is guaranteed to have only one instance for the entire app, I don't see
why these shouldn't just become member variables.
Status: NEW → ASSIGNED
Keywords: mlk
Priority: -- → P3
Whiteboard: [patch][tind-mlk]
Target Milestone: --- → mozilla1.2beta

Comment 2

16 years ago
Comment on attachment 100152 [details] [diff] [review]
patch (simple approach)

oops.
sr=alecf
Attachment #100152 - Flags: superreview+

Comment 3

16 years ago
as for why they aren't member vars, I don't know. Its a pattern that we use all
over the place in datasources so that we don't waste memory if there are
multiple instances of the datasource.. though frankly datasources like this will
really only have one instance.
Comment on attachment 100152 [details] [diff] [review]
patch (simple approach)

r=bryner
Attachment #100152 - Flags: review+
Fix checked in to trunk, 2002-09-23 20:20 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.