170179 - nsWindowDataSource leaks some RDF stuff

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsWindowDataSource leaks its RDF global variables, since its gRefCnt is never
incremented.  I'll attach one possible patch for fixing it, although if the
object is guaranteed to have only one instance for the entire app, I don't see
why these shouldn't just become member variables.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (simple approach)

Comment 2

[Alec Flett]

Comment on attachment 100152 [details] [diff] [review]
patch (simple approach)

oops.
sr=alecf

Comment 3

[Alec Flett]

as for why they aren't member vars, I don't know. Its a pattern that we use all
over the place in datasources so that we don't waste memory if there are
multiple instances of the datasource.. though frankly datasources like this will
really only have one instance.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 100152 [details] [diff] [review]
patch (simple approach)

r=bryner

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2002-09-23 20:20 PDT.