Closed Bug 1701790 Opened 3 years ago Closed 3 years ago

Migrate ResourceWatcher to become a command

Categories

(DevTools :: General, task)

task

Tracking

(firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 4 open bugs)

Details

Attachments

(4 files, 1 obsolete file)

Bug 1693491 could be used as a template.

We would benefit from migrating ResourceWatcher to become ResourceCommand.
We wouldn't have to manually instantiate it here and there (especially in tests).
It would be easily available to all commands as well to all frontend codebase.
And ResourceWatcher would be less special and would not longer require its own devtools/shared/resources folder.

This would also allow to followup on this review comment on the WebExt codebase:
https://phabricator.services.mozilla.com/D108994#inline-613227

Blocks: 1708635
Assignee: nobody → poirot.alex

$ sed -i 's/ResourceWatcher/ResourceCommand/g' $(egrep -rl 'ResourceWatcher' devtools/)

$ sed -i 's/resourceWatcher/resourceCommand/g' $(egrep -rl 'resourceWatcher' devtools/)

Blocks: 1709063
Blocks: 1709065
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd3c9b1482c7
Migrate ResourceWatcher to become ResourceCommand. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8f4205a1a369
Stop using ResourceWatcher symbol for fetch resource types. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6cb7502fc1a2
Mass replace ResourceWatcher by ResourceCommand r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2d3ea7c0d695
Mass replace resourceWatcher with resourceCommand. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/3fc4edd663d9
Move ResourceWatcher tests to their new folder. r=nchevobbe
Attachment #9219471 - Attachment is obsolete: true
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00402683d69b
Migrate ResourceWatcher to become ResourceCommand. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/3225a59ac7ad
Move ResourceWatcher tests to their new folder. r=nchevobbe
Regressions: 1709313
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Flags: needinfo?(poirot.alex)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: