Migrate ResourceWatcher to become a command
Categories
(DevTools :: General, task)
Tracking
(firefox90 fixed)
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 4 open bugs)
Details
Attachments
(4 files, 1 obsolete file)
Bug 1693491 could be used as a template.
We would benefit from migrating ResourceWatcher to become ResourceCommand.
We wouldn't have to manually instantiate it here and there (especially in tests).
It would be easily available to all commands as well to all frontend codebase.
And ResourceWatcher would be less special and would not longer require its own devtools/shared/resources folder.
This would also allow to followup on this review comment on the WebExt codebase:
https://phabricator.services.mozilla.com/D108994#inline-613227
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
$ sed -i 's/ResourceWatcher/ResourceCommand/g' $(egrep -rl 'ResourceWatcher' devtools/)
Assignee | ||
Comment 4•3 years ago
|
||
$ sed -i 's/resourceWatcher/resourceCommand/g' $(egrep -rl 'resourceWatcher' devtools/)
Assignee | ||
Comment 5•3 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd3c9b1482c7 Migrate ResourceWatcher to become ResourceCommand. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/8f4205a1a369 Stop using ResourceWatcher symbol for fetch resource types. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/6cb7502fc1a2 Mass replace ResourceWatcher by ResourceCommand r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/2d3ea7c0d695 Mass replace resourceWatcher with resourceCommand. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/3fc4edd663d9 Move ResourceWatcher tests to their new folder. r=nchevobbe
Comment 7•3 years ago
|
||
Backed out 5 changesets (bug 1701790) for bc failures in browser_ext_devtools_network_targetSwitch.js.
https://hg.mozilla.org/integration/autoland/rev/c97286566c4529deeb7c1da7ce593f83b0699992
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=3fc4edd663d92d2f6868a9c44ae9e99776c901de&selectedTaskRun=bYquoPDTQFOnzLlEUOev5A.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=338565808&repo=autoland&lineNumber=8059
Updated•3 years ago
|
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00402683d69b Migrate ResourceWatcher to become ResourceCommand. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/3225a59ac7ad Move ResourceWatcher tests to their new folder. r=nchevobbe
Comment 9•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/00402683d69b
https://hg.mozilla.org/mozilla-central/rev/3225a59ac7ad
Assignee | ||
Updated•2 years ago
|
Description
•