1701796 - Invalid Win32k use in content process [xul!mozilla::widget::WinUtils::IsTouchDeviceSupportPresent]

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Chris Martin [:cmartin]]

GetSystemMetrics() is called here

Call stack:

win32u!NtUserCallNoParam
USER32!GetSystemMetrics+0x131
xul!mozilla::widget::WinUtils::IsTouchDeviceSupportPresent+0xf [c:\moz\mozilla-central\widget\windows\WinUtils.cpp @ 1795]
xul!mozilla::dom::TouchEvent::PlatformSupportsTouch+0x26 [c:\moz\mozilla-central\dom\events\TouchEvent.cpp @ 208]
xul!mozilla::dom::TouchEvent::PrefEnabled+0x95 [c:\moz\mozilla-central\dom\events\TouchEvent.cpp @ 242]
xul!mozilla::PresShell::AccessibleCaretEnabled+0x18e [c:\moz\mozilla-central\layout\base\PresShell.cpp @ 782]
xul!mozilla::PresShell::Init+0x2e9 [c:\moz\mozilla-central\layout\base\PresShell.cpp @ 967]
xul!mozilla::dom::Document::CreatePresShell+0x9c [c:\moz\mozilla-central\dom\base\Document.cpp @ 6629]
xul!nsDocumentViewer::InitPresentationStuff+0x5b [c:\moz\mozilla-central\layout\base\nsDocumentViewer.cpp @ 724]
xul!nsDocumentViewer::InitInternal+0x3c1 [c:\moz\mozilla-central\layout\base\nsDocumentViewer.cpp @ 929]
xul!nsDocumentViewer::Init+0x20 [c:\moz\mozilla-central\layout\base\nsDocumentViewer.cpp @ 700]
xul!nsDocShell::SetupNewViewer+0x355 [c:\moz\mozilla-central\docshell\base\nsDocShell.cpp @ 8315]
xul!nsDocShell::Embed+0x42 [c:\moz\mozilla-central\docshell\base\nsDocShell.cpp @ 5805]
xul!nsDocShell::CreateAboutBlankContentViewer+0x567 [c:\moz\mozilla-central\docshell\base\nsDocShell.cpp @ 6892]
xul!nsDocShell::CreateContentViewerForActor+0x53 [c:\moz\mozilla-central\docshell\base\nsDocShell.cpp @ 6929]
xul!nsWebBrowser::Create+0x3ba [c:\moz\mozilla-central\toolkit\components\browser\nsWebBrowser.cpp @ 162]
xul!mozilla::dom::BrowserChild::Init+0xc8 [c:\moz\mozilla-central\dom\ipc\BrowserChild.cpp @ 468]
xul!mozilla::dom::ContentChild::RecvConstructBrowser+0x244 [c:\moz\mozilla-central\dom\ipc\ContentChild.cpp @ 1738]

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1701796: Move IsTouchDeviceSupportPresent to LookAndFeel remoting to prevent win32k usage in the content process. r=emilio!

Comment 2

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/jobs?repo=try&duplicate_jobs=visible&selectedTaskRun=boSnTd-8RUO0uh_AtN6wwg.0&revision=7e7837cfd8d5be0f248d21945097d9ae1d1a6d51

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ad7f37e5923e