1701861 - about:telemetry - center vertically text in section picker links

Status: VERIFIED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot from 2021-03-30 06-15-40.png

Affected versions

• 89.0a1(2021-03-28), 88.0b2;

Affected platforms

• Ubuntu 20, Windows 10;

Steps to reproduce

1. Launch Firefox and access about:telemetry;
2. Hover over the section links inside the page;

Enhancement suggestion

• text can be vertically-centered inside the "button";

Actual result

• text appears offset from vertical-center;
• this is not a bad design, especially for elements that have subsections such as Environment Data or Scalars etc.;

Regression range

• most likely not a regression;

Additional notes

• attached screenshot to best illustrate the suggestion.

Comment 1

[Abhir Raj Shrivastava]

Hi, I would like to work on this issue.

Comment 2

[Chris H-C :chutten]

Please do! Let me know if you have any questions.

Comment 3

[Chris H-C :chutten]

Unassigning due to inactivity.

Comment 4

[Varun Sharma]

I would like to work upon this . Can you provide me any doc from where I can get the codebase or how can I locally run on it ?

Comment 5

[Chris H-C :chutten]

Certainly!
You'll find here the instructions on how to download and build the Firefox source code

• If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
• You can also read the Developer Guide, which has answers to most development questions.

Comment 6

[Varun Sharma]

Thanks , I will am all on it . Will update you if I have any query .

Comment 7

[Chris H-C :chutten]

Oh, geez, I gave you the wrong link. The correct place to learn how to get started on working on Firefox is here. We recently reorganized some docs so I'm still playing catch-up. Sorry for the confusion!

Comment 8

[Varun Sharma]

it's running perfectly . Now for the bug it says the affected version 89.0a1(2021-03-28), 88.0b2; But I have version 94 of nightly in local build.
Should I do changes in the recent version (i.e. 94) ? or I have to first go to Mozilla version 89.0a1(2021-03-28) and 88.0b2 and then do changes in those two versions only ?
In short I have v94 and windows 10 Pro . Anything that I have to do before making changes to the code ? like going to v88 or I have to go to windows 10 otherwise I can't see the bug for enhancement ?

Comment 9

[Jan-Erik Rediger [:janerik]]

No, this bug still exists in all versions. You can work from the latest code base, and on Windows.

Comment 10

[Varun Sharma]

Just wanted to update you that I am working on it and getting familiar with the codebase .

Comment 11

[Saman]

Hi, I am an outreachy applicant I want to work on this bug kindly assign it to me Thank you.

Comment 12

[Chris H-C :chutten]

Please go ahead and work on it. When you submit a patch, the bots will assign the bug to you.

Comment 13

[Saman]

Ok on it Thank you.

Comment 14

[ola-oluwa]

chutten please what do you mean when you said text can be vertically centered inside the "button".

Comment 15

[ola-oluwa]

Attachment: Bug 1701861- vertically center text in about:telemetry. r?chutten

Depends on D129133

Comment 16

[Cristian Fogel [:cfogel]]

(In reply to ola-oluwa from comment #14)

chutten please what do you mean when you said text can be vertically centered inside the "button".

Comment 17

[Chris H-C :chutten]

Oh, I meant that, as shown in the attached screenshot the text is a little too high within its box. If I exaggerate it, it looks like this:

-----
Some text


----

Ideally it'd look like

-----

Some text

-----

I restate it in different words in this comment on the proposed patch, if that helps.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 19

[Danny Colin [:sdk]]

Hey :chutten do you mind if I take a stab at this bug?

Comment 20

[Danny Colin [:sdk]]

Attachment: Bug 1701861 - Fix category name vertical alignment r?chutten

Comment 21

[Chris H-C :chutten]

No need to needinfo me, you're good to go.

Comment 22

[Danny Colin [:sdk]]

Attachment: Bug 1701861 - Use justify-content instead of line-height r?chutten

Depends on D149472

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73567df3043d
Fix category name vertical alignment r=chutten

Comment 24

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/73567df3043d

Comment 25

[Ardelean Oana, Desktop QA [:oardelean]]

Hello,
I confirm this enhacement is implemented on Firefox 103.0b7(build ID: 20220710185935) and Nightly 104.0a1(build ID: 20220712093327) on Ubuntu 22.04, Windows 10 64-bits and macOS 12.