Closed Bug 1701883 Opened 8 months ago Closed 8 months ago

Restore defaults is always available if extensions.pocket.enabled is set to false in about:config

Categories

(Firefox :: Toolbars and Customization, defect, P5)

Firefox 89
Desktop
All
defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- disabled
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: atrif, Assigned: thecount)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-toolbar])

Attachments

(2 files)

Attached image pocke5_cust.gif

Affected versions

  • 89.0a1 (20210329214331)

Affected platforms

  • Windows 10x64
  • mac10.15.7

Steps to reproduce

  1. Open Firefox and set extensions.pocket.enabled:false in about:config.
  2. Enter the customize mode and click multiple times on Restore defaults.

Expected result

  • Restore Defaults is greyed out or can be selected only once like in previous builds.

Actual result

  • Restore defaults can be selected multiple times

Regression range

Notes

  • Attached a screen recording.
  • This happens with proton enabled and disabled as well.
Has Regression Range: --- → yes
Has STR: --- → yes

Why should we track regressions that happen in non default configurations? (extensions.pocket.enabled:false is not the default behavior)
Or maybe I'm missing that this gets set for specific locales or user segments?

Flags: needinfo?(alexandru.trif)
Priority: -- → P3

(In reply to Romain Testard [:RT] from comment #1)

Why should we track regressions that happen in non default configurations? (extensions.pocket.enabled:false is not the default behavior)
Or maybe I'm missing that this gets set for specific locales or user segments?

Sorry but I don't know if extensions.pocket.enabled will be set to false without using about:config or for specific locales but this was encountered while testing scenarios from here: https://bugzilla.mozilla.org/show_bug.cgi?id=1693376#c2.

Flags: needinfo?(alexandru.trif)

Policy changes could have it set to false by default, so it's not just a pref flip.

I think this should be fixed, but I don't personally think it's worth blocking or uplifting.

OK thanks for clarifying, marking as P5 to reflect the low occurence/low impact of the bug

Priority: P3 → P5
Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/5c53a01b4730
Fix Pocket button default placement if pref is false. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Restore defaults is no longer always available if extensions.pocket.enabled:false in about:config when using Firefox 90.0a1 (20210510093555) on Windows 10x64 and macOS 11.3.1. Closing this as verified. Thank you!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.