1701883 - Restore defaults is always available if extensions.pocket.enabled is set to false in about:config

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P5)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: pocke5_cust.gif

Affected versions

• 89.0a1 (20210329214331)

Affected platforms

• Windows 10x64
• mac10.15.7

Steps to reproduce

1. Open Firefox and set extensions.pocket.enabled:false in about:config.
2. Enter the customize mode and click multiple times on Restore defaults.

Expected result

• Restore Defaults is greyed out or can be selected only once like in previous builds.

Actual result

• Restore defaults can be selected multiple times

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9768659de9578807afd741533dc0be9cc02d3634&tochange=94729075e1a328aa06e716beede2582542c994c5

Notes

• Attached a screen recording.
• This happens with proton enabled and disabled as well.

Comment 1

[Romain Testard [:RT]]

Why should we track regressions that happen in non default configurations? (extensions.pocket.enabled:false is not the default behavior)
Or maybe I'm missing that this gets set for specific locales or user segments?

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Romain Testard [:RT] from comment #1)

Why should we track regressions that happen in non default configurations? (extensions.pocket.enabled:false is not the default behavior)
Or maybe I'm missing that this gets set for specific locales or user segments?

Sorry but I don't know if extensions.pocket.enabled will be set to false without using about:config or for specific locales but this was encountered while testing scenarios from here: https://bugzilla.mozilla.org/show_bug.cgi?id=1693376#c2.

Comment 3

[Scott [:thecount] Downe]

Policy changes could have it set to false by default, so it's not just a pref flip.

I think this should be fixed, but I don't personally think it's worth blocking or uplifting.

Comment 4

[Romain Testard [:RT]]

OK thanks for clarifying, marking as P5 to reflect the low occurence/low impact of the bug

Comment 5

[Scott [:thecount] Downe]

Attachment: Bug 1701883 - Fix Pocket button default placement if pref is false.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c53a01b4730
Fix Pocket button default placement if pref is false. r=Gijs

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5c53a01b4730

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Restore defaults is no longer always available if extensions.pocket.enabled:false in about:config when using Firefox 90.0a1 (20210510093555) on Windows 10x64 and macOS 11.3.1. Closing this as verified. Thank you!