1701901 - Search mode chiclet is missing X button in closed state

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea], Desktop QA]

Attachment: search mode - closed state

Affected versions

• Fx89.0a1 20210329214331

Affected platforms

• Windows 10 64-bit
• Ubuntu 18.04
• Mac OSX 11.2.3

Preconditions
The following prefs are enabled in about:config:

• browser.proton.enabled
• browser.proton.toolbar.enabled
• browser.proton.urlbar.enabled

Steps to reproduce

1. Launch Firefox and focus the address bar.
2. Select a search shortcut to enter search mode
3. Focus something in page
4. Observe the search mode button and it's styling

Expected result

• Close button [x] is present and it reflects the closed state styling figma

Actual result

• Close button [x] is not present when the address bar is out of focus

Regression range

• This is not a regression

Comment 1

[Marco Bonardo [:mak]]

Interesting, it's the first time I notice that. We use the label box in this state and that box doesn't have the X button, we may have to use the search mode chiclet instead in both modes.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1701901: Show urlbar-search-mode-indicator always upon search mode.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aacc94d35e60
Show urlbar-search-mode-indicator always upon search mode. r=adw,harry

Comment 4

[Marco Bonardo [:mak]]

Daisuke, could you please file a follow-up bug blocking Bug 1698882 to remove the code driving the old label box solution once Proton is released, since we won't use it anymore.

Once this merges we should also ask for uplift.

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/aacc94d35e60

Comment 6

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your direction, Marco.
I will do them.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9217324 [details]
Bug 1701901: Show urlbar-search-mode-indicator always upon search mode.

Beta/Release Uplift Approval Request

• User impact if declined: As the close button is not displayed, will not be Proton behavior we intended.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Because this patch changes only CSS.
• String changes made/needed: none

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9217324 [details]
Bug 1701901: Show urlbar-search-mode-indicator always upon search mode.

Approved for 89 beta 6, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/dae943335535

Comment 10

[Pablo]

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b7

i will open a new bug since i noticed that the search mode box under ubuntu is grey while on windows and Mac it is white.