The pocket button remains pressed after "pocketing" an article
Categories
(Firefox :: Pocket, defect, P3)
Tracking
()
People
(Reporter: gsvelto, Unassigned)
Details
I've just noticed this with yesterday's nightly on Windows. If I click the pocket button it will turn red and display the usual banner. If I click outside of the banner afterwards the button briefly reverts to its black & white non-pressed state, then goes back to red and remains that way. The button resets to its normal appearance only after browsing to another page or reloading the tab.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
I can reproduce in windows, but not my primary Linux machine.
I'll take a look at the code to see if anything looks suspicious, but ideally we do a bisect on an impacted machine with a local build and figure out where this regressed.
|
|
||
Comment 2•5 years ago
|
||
Could be a race condition.
When we open the panel, we set the icon with an open state, which makes it red.
When the panel fires the hiding event, we check to see if it's pocketed.
I suspect the speed of which the hiding event is triggered isn't working well with the moment the open state is removed.
Description
•