170200 - Classic/Win9x toolbar buttons shouldn't have extra border

Status: RESOLVED EXPIRED

(SeaMonkey :: Themes, defect)

Description

[Greg Valure]

As pointed out to me by Joonas Marttila, and seen in the screen shot, non-XP
Windows apps don't use the dark border around toolbar buttons anymore.

Comment 1

[Greg Valure]

Attachment: Comparison from Joonas

Comment 2

[Greg Valure]

Attachment: Patch

This patch changes the outer border colors to be the inner border colors, and
makes the inner border colors transparent.  We can't just make the borders 1px
because there are things in bookmarksToolbar.css that depend on them being 2px.
 We can't change bookmarksToolbar.css because the Mac and Unix versions still
use 2px, and there aren't separate bookmarksToolbar.css files for each
platform.

The border size changes in toolbarbutton-menubutton-dropmarker/button are to
keep the buttons the same size as they were before.

Comment 3

[Greg Valure]

Attachment: Patch 2

Actually, it's probably not worth the extra code wierdness to save two pixels. 
This patch is much cleaner and closer to the original.

Comment 4

[Joonas]

Thanks for filing the bug and making the patch.

A problem: if you have the sidebar open, hovering over "Tabs" or the "x" close
button only shows a partial border (right and bottom borders are missing). You
see, the sidebar header's background color is currently taken from Control
panel/Display/Appearance -> Inactive title bar color. And that color seems to be
the same as ThreeDShadow, at least on my system (I use the default Windows color
scheme so I'm not alone with my problem).

I can think of two ways of fixing this:

1) file a new bug to change the background color of the Sidebar header. This
would be good, because I think it currently looks like the Sidebar is "inactive"
because it uses the same color as inactive windows. A better choice for the
background color would IMHO be the same background color that's used everywhere
else (gray or whatever).

2) change the ThreeDShadow color to black in Sidebar header buttons.

Comment 5

[Joonas]

I also noticed that fixing this bug makes the ugly Go and Search buttons look
even uglier. Fixing those buttons might be outside the scope of this bug,
however... Your choice.

For example in Internet Explorer the go button is "flat" and gets a 1 px
mouseover border like the navigation buttons and in Opera the go etc. buttons
look like standard Windows buttons and don't have a mouseover effect.

In Mozilla it's something in between.

Comment 6

[Greg Valure]

I see what you mean about the sidebar.  However, like the bookmarks, the sidebar
styles are cross-platform, so we can't change them to only suit Windows.  I'll
wait for the reviewer's comments on the best way to handle this, but I think we
probably need to subclass buttons that go on title bars.

I don't see a difference in Go and Search.  Do you mean they're uglier because
they match even less now?  DOM Inspector shows they use completely different
classes, so I think that's another bug.

Comment 7

[Joonas]

Yes, I meant that making the navigation buttons prettier makes Go and Search
look even more out of place. Your patch doesn't change them.

And you're probably right, that's another bug.

Comment 8

[Greg Valure]

Back to default owner.  Sorry, time's been short.

Comment 9

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 10

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 11

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 12

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420