1702144 - In private browsing the recently closed tabs/windows, clear history cannot be clicked

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Raluca Popovici, Desktop QA]

Attachment: 2021-03-31_10h44_38.mp4

[Affected versions]
Beta 88
Nightly 89

[Affected platforms]
Win 10

[Precondition]
The following pref is set on true:

• browser.proton.enabled

[Steps to reproduce]

1. Open the Firefox browser
2. Open 2 new windows and close them
3. Reach the History submenu from the Hamburger menu
4. Recently Closed windows is active and clickable
5. Open a new private window
6. Reach the History submenu from the Hamburger menu
7. Close Private window
8. Open again a new private window
9. Reach again the History submenu from the Hamburger menu

Actual result:
The recently closed tabs/windows appears to be active and cannot be clicked. Please see screen recording.

Expected result:
Only Recently Closed window should be active and clickable. The recently closed tabs option should be greyed out(inactive)

Note: With preff off, the recently closed tabs/windows are clickable but are empty

Comment 1

[Alin Ilea, Desktop Test Engineering]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e47746f9045400fdccc8e5867520a188ac602e5a&tochange=17ee13de98831289b549b6656718fe3cc72c3694

Comment 2

[Alin Ilea, Desktop Test Engineering]

Romain, could please set the priority for this bug when you get a chance? This is a S2 from our perspective..
Thanks!

Comment 3

[Emma Malysz]

Attachment: Bug 1702144, ensure recently closed tabs button is disabled when there are none

Removes macos rule that overrides disabled css rules
Removes early return to ensure the menu is created correctly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c828725294d2
ensure recently closed tabs button is disabled when there are none r=Gijs

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c828725294d2

Comment 6

[Raluca Popovici, Desktop QA]

Verified - Fixed in latest Nightly 89.0a1 (2021-04-19) with proton pref on, using Windows 10x64 and Mac 11.