1702195 - Pocket is not working if it was deactivated once and reactivated from about:config

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Catalin Sasca, Desktop QA [:csasca]]

Affected versions

• Firefox 89.0a1

Affected platforms

• macOS 10.15.7
• Windows 10
• Ubuntu 20.04

Steps to reproduce

1. Launch Firefox
2. Access about:config and set extensions.pocket.enabled to false and then to true
3. Click on the Pocket button found in toolbar

Expected result

• Pocket dropdown works as expected

Actual result

• Pocket is not working anymore

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the following attachment

Comment 1

[Scott [:thecount] Downe]

The regression range is very likely bug 1693376

Comment 2

[Scott [:thecount] Downe]

I needed to make a small change to steps to reproduce.

1. Launch Firefox
2. Click the Pocket button.
3. Access about:config and set extensions.pocket.enabled to false and then to true
4. Click on the Pocket button found in toolbar

For me without that second step it works fine. It's something about opening Pocket before turning it off and on.

Comment 3

[Scott [:thecount] Downe]

Attachment: Bug 1702195 - Properly re add widget view and hide events if toggled off and on.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47464781b8e5
Properly re add widget view and hide events if toggled off and on. r=Gijs

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/47464781b8e5

Comment 6

[Catalin Sasca, Desktop QA [:csasca]]

Verified that this issue is fixed on Firefox 89.0a1 (2021-04-14). Tests were performed on macOS 11.2.3, Ubuntu 20.04 and Windows 10.