Closed Bug 1702195 Opened 2 years ago Closed 2 years ago

Pocket is not working if it was deactivated once and reactivated from about:config

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Version:
Firefox 89
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: csasca, Assigned: thecount)

References

(Blocks 2 open bugs)

Details

(Keywords: regressionwindow-wanted, Whiteboard: [proton-toolbar])

Attachments

(1 file)

Bug 1702195 - Properly re add widget view and hide events if toggled off and on.
48 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • Firefox 89.0a1

Affected platforms

  • macOS 10.15.7
  • Windows 10
  • Ubuntu 20.04

Steps to reproduce

  1. Launch Firefox
  2. Access about:config and set extensions.pocket.enabled to false and then to true
  3. Click on the Pocket button found in toolbar

Expected result

  • Pocket dropdown works as expected

Actual result

  • Pocket is not working anymore

Regression range

  • Will see for a regression

Additional notes

  • The issue can be seen in the following attachment
Has Regression Range: --- → no
Has STR: --- → yes
Assignee: nobody → sdowne

The regression range is very likely bug 1693376

Priority: -- → P3

I needed to make a small change to steps to reproduce.

  1. Launch Firefox
  2. Click the Pocket button.
  3. Access about:config and set extensions.pocket.enabled to false and then to true
  4. Click on the Pocket button found in toolbar

For me without that second step it works fine. It's something about opening Pocket before turning it off and on.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/47464781b8e5
Properly re add widget view and hide events if toggled off and on. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/47464781b8e5

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified that this issue is fixed on Firefox 89.0a1 (2021-04-14). Tests were performed on macOS 11.2.3, Ubuntu 20.04 and Windows 10.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
You need to log in before you can comment on or make changes to this bug.