Open Bug 1702211 Opened 5 years ago Updated 4 years ago

Rename toolbox event "ready" to "toolbox-ready"

Categories

(DevTools :: Framework, task, P5)

task

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

The toolbox emits a "ready" event. This name is very generic, which makes it hard to grep and therefore it's hard to track call sites for the event.

We could rename the event to "toolbox-ready", however this name is already used by gDevTools (https://searchfox.org/mozilla-central/rev/9043e515e9608cc55b252a40cb2dfb6f767bcffd/devtools/client/framework/devtools.js#658).

So we could additionally prefix the toolbox-related events emitted by gDevTools with "devtools":

  • "toolbox-ready" -> "devtools-toolbox-ready"
  • "toolbox-destroy" -> "devtools-toolbox-destroy"
  • "toolbox-destroyed" -> "devtools-toolbox-destroyed"

(need to be a bit careful with those, they are used outside of devtools: https://searchfox.org/mozilla-central/search?path=&q=toolbox-destroy)

Depends on: 1702061

The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Framework
You need to log in before you can comment on or make changes to this bug.