1702227 - Don't add `WIP:` prefix when submitting without reviewers

Status: NEW

(Conduit :: moz-phab, enhancement, P2)

Description

[Andrew Halberstadt [:ahal]]

I really like the new WIP detection when no reviewers are supplied (i.e, marking the revision as "Changes Planned"). It's a great indicator that the revision is actually not ready for review (a workflow I use all the time).

However the WIP: prefix that gets added is a bit annoying as it doesn't get removed when updating the revision. I think either:
A) It should automatically be removed when adding a reviewer (which might be hard if doing so from Phabricator UI)
B) Just not get added in the first place as it's kind of redundant with "Changes Planned".

I'd vote B since it seems simpler.

Comment 1

[Andrew Halberstadt [:ahal]]

I also noticed that we don't strip WIP when pushing:
https://hg.mozilla.org/integration/autoland/rev/c631966a64c0ffefbbba949c28008b0b375f7dd5

This is an easy footgun for folks to run into. We should at least automatically remove it if we're going to automatically add it (though I still vote for not adding it in the first place) :)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah, I was about to file this. All these recent commits have landed with the WIP prefix:

WIP: Bug 1703707 - Replace cross-process OMXClient call with IPC to enable isolated process in Android r=geckoview-reviewers,aklotz,agi,jolin
WIP: Bug 1696531: use python3 for xpcshell tests r=bhearsum
WIP: Bug 1701283 - Catch security exceptions thrown by Android Autofill Manager r=geckoview-reviewers,aklotz
WIP: Bug 1675375 Part 7: Update expectations in helper_hittest_clippath.html. r=botond
WIP: Bug 1675375 Part 6: Break test_group_hittest.html into parts. r=botond
WIP: Bug 1675375 Part 5: Add a polygon clip test for Fission WebRender. r=gw
WIP: Bug 1675375 Part 4: Perform the polygon hit test in WebRender, and add unit tests. r=gw
WIP: Bug 1675375 Part 3: Stub in polygon clipping in WebRender. r=gw
WIP: Bug 1675375 Part 2: Add a polygon clips to image masks. r=gw
WIP: Bug 1675375 Part 1: Define WebRender structures for polygons. r=gw
WIP: Bug 1701587 Part 2: Upgrade asserts in AutoTransactionSender to run in release builds. r=kvark
WIP: Bug 1685183 Part 3: Remove remaining references to PluginInstanceChild. r=jgilbert
WIP: Bug 1703141 - Prevent infinite loop in gradient fast-path. r=gfx-reviewers,lsalzman
WIP: Bug 1674157 - Remove tp6 aple google-sheets yahoo-news yandex tests r=perftest-reviewers,davehunt
WIP: Bug 1701587: Add asserts to AutoTransactionSender to prevent storage of NULL pointers. r=kvark
WIP: Bug 1700760 - Use the nimbus-desktop-defaults collection for Nimbus defaults r=k88hudson
WIP: Bug 1703257 - Add Tajik (tg) to Nightly builds r=firefox-build-system-reviewers,nalexander
WIP: Bug 1702537: fix eslint check passes browser/extensions/screenshots/background/deviceInfo.js r=emalysz
WIP: Bug 1700132 - Annotate an intermittent test failure in forms/input/number/focus-handling.html.
WIP: Bug 1638991 - [telemetry-tests-client] Don't use relative imports in telemetry_harness. CLOSED TREE

That's a fair amount IMO.

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Note that this also causes emails to be broken up into two threads: one for events to the revision that are prefixed by WIP:, and another thread for all those that aren't prefixed by WIP:.