Closed Bug 1702232 Opened 5 years ago Closed 5 years ago

Don't cache linear gradients with swgl

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: nical, Assigned: nical)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

SWGL apparently can render linear gradients faster than it can read from the texture cache.

Unfortunately we have a "fast path" which caches some linear gradients. It's quite a bit faster on hardware but not helping SWGL.

Severity: -- → N/A
Type: defect → enhancement
Priority: -- → P3
Assignee: nobody → nical.bugzilla
Status: NEW → ASSIGNED

gradient-move-stops.html ends up failing because a gradient stop is offset by a small amount but it causes a large amount of pixels to differ by 255, beyond what is reasonable to mark with fuzzy thresholds.

Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4ce7cd804c5 Disable cached gradients with SWGL. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/2dc7e2153f82 Adjust reftest expectations. r=lsalzman
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: