1702237 - Search mode chiclet can get overloaded with Switch to tab text

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Harry Twyford]

STR

1. Open Tabs search mode by typing % or clicking the tabs search shortcut.
2. Press the down arrow until a non-remote Switch-to-Tab result is selected.
3. Press Esc.

Expected results: The search mode chiclet reads "Tabs"
Actual results: The search mode chiclet reads "Switch to tab:Tabs"

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I cannot reproduce this, does it require additional settings? Is it a regression?

Comment 2

[Harry Twyford]

Attachment: Screen Recording 2021-03-31 at 11.01.41 AM.mov

I don't think so. I just reproduced it on a fresh profile. Maybe it's a Mac only thing? Screen recording attached.

Comment 3

[Harry Twyford]

It's not a recent regression. It's present in a 2021-01-01 build. It's just more visible in Proton because we jump right from using the search mode chiclet to using the label box when pressing Esc, rather than having the intermediary step of the expanded-and-closed state.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ah yes, now I see it, thanks.

Comment 5

[Harry Twyford]

Setting P2 since this is a longstanding issue not introduced by Proton changes.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1702237: Add a test for chiclet in switching tab mode.r?harry!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7338e5d940a6
Make chiclet label properly upon tabs mode.r=harry

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on browser_switchToTab_chiclet.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Csuccess%2Cretry%2Crunning%2Cpending%2Crunnable&fromchange=7338e5d940a6afb62b264b72e0aa9ccfad4f0329&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-browser-chrome-e10s%2Cbc8&selectedTaskRun=O9JjpslkT0Ku2ZBuMjQylA.0&tochange=d7ac7c539f840bb82d86340844aaa47d1a120b20

Failure log: https://treeherder.mozilla.org/logviewer?job_id=337806527&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/d7ac7c539f840bb82d86340844aaa47d1a120b20

Comment 9

[Daisuke Akatsuka (:daisuke)]

Thank you very much for letting me know.
I address it.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7517d291e2f5
Make chiclet label properly upon tabs mode.r=harry

Comment 11

[Iulian Moraru]

Backed out changeset 7517d291e2f5 (bug 1702237) for causing Browser-Chrome failures at browser_switchToTab_chiclet.js .

Push with failures

Failure log

Backout link

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/220b10e62a85
Add a test for chiclet in switching tab mode.r=harry

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/220b10e62a85

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

A test landed here but no actual changes since the production changes were backed out. Should this bug be re-opened?

Comment 15

[Daisuke Akatsuka (:daisuke)]

Thank you very much for the notice, Jared!
Actually, this issue was fixed by bug 1701901, coincidentally.
But since there was no test for this issue, I added it.
Thus, I don't think we have to re-open.

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Hey, harry! needinfo'ing you because I suspect this is afterhours for daisuke - does this block MR1? If so, can you request beta approval sometime today? And if it doesn't block, can you set the 89 status flag to wontfix?

Comment 17

[Harry Twyford]

No, this bug was fixed by bug 1701901. This patch just adds a test for that bug. It's neither a critical issue nor a risky fix, so I don't think uplifting the test is necessary.

Comment 18

[Cristian Baica [:cbaica], Release Desktop QA]

I've manged to reproduce the issue using Fx86.0a1.
The issue is verified fixed using Fx90.0a1 and Fx89.0b10 on Windows 10 and Ubuntu 18.04. The chiclet correctly reads 'Tabs'.