<input type="checkbox" checked="" disabled="" name="Test"> should have more contrast
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | verified |
firefox90 | --- | verified |
People
(Reporter: aryx, Assigned: emilio)
References
Details
Attachments
(6 files)
Windows 8.1, latest 89.0a1 Nightly
<input type="checkbox" checked="" disabled="" name="Test">
should have more contrast.
The native theme has a black checkmark on a grey background.
Reporter | ||
Comment 1•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
We always check whether something is disabled first so they're just
noise.
No behavior change.
Assignee | ||
Comment 3•3 years ago
|
||
Use a more opaque checkmark color.
Depends on D110448
Assignee | ||
Comment 4•3 years ago
|
||
No behavior change.
Depends on D110449
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/70ced96f812f Remove useless !isDisabled checks in nsNativeBasicTheme. r=mstange https://hg.mozilla.org/integration/autoland/rev/50fa70692185 Improve contrast of disabled checkmarks and radio buttons. r=mstange https://hg.mozilla.org/integration/autoland/rev/7a7ccd9d5426 Minor cleanup to ComputeCheckboxColors. r=mstange
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70ced96f812f
https://hg.mozilla.org/mozilla-central/rev/50fa70692185
https://hg.mozilla.org/mozilla-central/rev/7a7ccd9d5426
Updated•3 years ago
|
Comment 7•3 years ago
|
||
I have reproduced the issue using STR from comment 0, on an affected Nightly build 2021-03-28.
The fix was verified using the latest Nightly 90.0a1 (2021-05-09) and Firefox 89.0b10 (2021-05-09) on Windows 10x64, Ubuntu 20.04 and macOS 10.15.
@Emilio, can you please confirm that the screenshot correctly represents the fix?
Updated•3 years ago
|
Description
•