Closed Bug 1702282 Opened 3 years ago Closed 3 years ago

<input type="checkbox" checked="" disabled="" name="Test"> should have more contrast

Categories

(Core :: Layout: Form Controls, defect)

defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified
firefox90 --- verified

People

(Reporter: aryx, Assigned: emilio)

References

Details

Attachments

(6 files)

Windows 8.1, latest 89.0a1 Nightly

<input type="checkbox" checked="" disabled="" name="Test"> should have more contrast.

The native theme has a black checkmark on a grey background.

Assignee: nobody → emilio

We always check whether something is disabled first so they're just
noise.

No behavior change.

Use a more opaque checkmark color.

Depends on D110448

No behavior change.

Depends on D110449

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70ced96f812f
Remove useless !isDisabled checks in nsNativeBasicTheme. r=mstange
https://hg.mozilla.org/integration/autoland/rev/50fa70692185
Improve contrast of disabled checkmarks and radio buttons. r=mstange
https://hg.mozilla.org/integration/autoland/rev/7a7ccd9d5426
Minor cleanup to ComputeCheckboxColors. r=mstange
QA Whiteboard: [qa-89b-p2]
Attached image checkmarkers.png

I have reproduced the issue using STR from comment 0, on an affected Nightly build 2021-03-28.
The fix was verified using the latest Nightly 90.0a1 (2021-05-09) and Firefox 89.0b10 (2021-05-09) on Windows 10x64, Ubuntu 20.04 and macOS 10.15.

@Emilio, can you please confirm that the screenshot correctly represents the fix?

Flags: needinfo?(emilio)

Yes, thanks

Flags: needinfo?(emilio)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: