Closed
Bug 1702287
Opened 4 years ago
Closed 4 years ago
Port bug 1701577: Make sure application menulist focus rings are not truncated
Categories
(Thunderbird :: Upstream Synchronization, task)
Thunderbird
Upstream Synchronization
Tracking
(thunderbird_esr78 unaffected)
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
|
959 bytes,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
We need to follow because of the Proton work they added an outline-offset of 2px and this makes the focus ring truncated on the "Files & Attachment" menulists.
|
Assignee | |
Comment 1•4 years ago
|
||
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9212869 -
Flags: review?(alessandro)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9212869 [details] [diff] [review]
1702287-actionMenu-focusring.patch
Review of attachment 9212869 [details] [diff] [review]:
-----------------------------------------------------------------
It's still slightly bit truncated on the first item as the top outline goes underneath the menulist header.
I tried with -3px offset but that's a bit too much, so I guess this is okay.
Attachment #9212869 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Comment 3•4 years ago
|
||
On Windows it's fully visible. I also tried it with browser.proton.enabled and then it looks better (no additional dotted focus ring around the label-box). Sooner or later we need to follow and enable it on TB too.
I heard they want to enable it on FX around April 6.
Keywords: checkin-needed-tb
Target Milestone: --- → 89 Branch
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d954ca828e37
Port bug 1701577: Make sure application menulist focus rings are not truncated. r=aleca
|
||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•