1702292 - Duplicated down arrow on the profiler panel's preset selector

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Florian Quèze [:florian]]

Attachment: Screenshot of profiler panel on Windows 7

See attached screenshot captured on Windows 7 (I also saw this on a Windows 8.0 machine).

Comment 1

[Julien Wajsberg [:julienw]]

I don't see this on Linux :/ Can someone test on MacOS please?
Is it Windows only? Is it a regression?

Comment 2

[Florian Quèze [:florian]]

(In reply to Julien Wajsberg [:julienw] from comment #1)

Is it Windows only? Is it a regression?

It's Windows < 10. And I don't know if we ever tested our profiler panel (since we removed the add-on) on Windows 7.

Comment 3

[Julien Wajsberg [:julienw]]

I feel like appearance: none doesn't work properly on this platform.

I'm moving this to the widgets team, they might have some more insight.

Comment 4

[Julien Wajsberg [:julienw]]

This is where the CSS code for this component is: [1] and below

[1] https://searchfox.org/mozilla-central/rev/4fa18c26fa907f38d56b599571b9846af1506f3c/browser/themes/shared/customizableui/panelUI.inc.css#2545-2559

Comment 6

[Julien Wajsberg [:julienw]]

Attachment: testcase-select.html

It would be interesting to know how this simple testcase behaves on various platforms.

Comment 7

[Julien Wajsberg [:julienw]]

Attachment: testcase screenshot on Linux

Comment 8

[Julien Wajsberg [:julienw]]

hey Florian, can you please have a look and share how attachment 9213987 [details] behaves on Windows (both 10 and 7)? And possibly MacOS too? Thanks!

Comment 9

[Julien Wajsberg [:julienw]]

It's Windows < 10. And I don't know if we ever tested our profiler panel (since we removed the add-on) on Windows 7.

Actually Florian, can you also double check if you enabled proton on some of your tries?

I see no difference for the simple testcase with/without proton, but I do see the double arrow for the profiler popup on Linux when I enable proton.

Comment 10

[Florian Quèze [:florian]]

On Windows 10, I initially didn't see it because I had the dark theme where it's not visible. On the default or light theme, the bug is visible on Windows 10.

On Mac I don't see the bug with the default settings, but it becomes visible if I enable browser.proton.enabled on about:config.

One of the down arrow comes from https://searchfox.org/mozilla-central/rev/be413c29deeb86be6cdac22445e0d0b035cb9e04/browser/themes/shared/customizableui/panelUI.inc.css#2611 This ::after pseudo element feels like a hack we should remove. It was apparently added in bug 1639144, but there's not a lot of explanation about why it was needed.

The other down arrow comes from https://searchfox.org/mozilla-central/rev/be413c29deeb86be6cdac22445e0d0b035cb9e04/toolkit/themes/shared/menulist.inc.css#56 (added in bug 1697863) when proton is enabled, and from native theming when proton is not enabled. Setting appearance: none; on the dropmarker element gets rid of it.

Comment 11

[Julien Wajsberg [:julienw]]

Yeah, I think we should look at removing all the custom styling code for this, like ntim suggested in bug 1702469.

Comment 12

[Itiel]

I think this is now fixed.

Comment 13

[Florian Quèze [:florian]]

(In reply to Florian Quèze [:florian] from comment #10)

One of the down arrow comes from https://searchfox.org/mozilla-central/rev/be413c29deeb86be6cdac22445e0d0b035cb9e04/browser/themes/shared/customizableui/panelUI.inc.css#2611 This ::after pseudo element feels like a hack we should remove. It was apparently added in bug 1639144, but there's not a lot of explanation about why it was needed.

This code was moved into a @media not (-moz-proton) block in bug 1703625, and entirely removed in bug 1714462.