Open Bug 1702325 Opened 5 years ago Updated 4 years ago

Add a pref to disable quickfind bar

Categories

(Toolkit :: Find Toolbar, defect, P3)

Firefox 87
defect

Tracking

()

UNCONFIRMED

People

(Reporter: ms, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Run https://ms0.github.io/music.html
Hold down single quote key [plays F5]

Actual results:

Find bar opens at bottom of screen and single quotes begin to appear there.
This seems similar to a very old bug (406495) which has been closed, but doesn't seem to have been resolved.

Expected results:

F5 should continue to play until single quote key is released. Find bar should not be invoked.

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core
Component: Audio/Video: Playback → DOM: UI Events & Focus Handling

The bot is probably wrong. I see this problem on other sites, e.g. wikipedia, although it seems to be a firefox "feature" that opens the find bar when you type a single quote. Other browsers don't do that.

Do you have "Search for text when you start typing" enabled in the preferences?

I can't reproduce using Finnish keyboard layout (" is shift+2)

Component: DOM: UI Events & Focus Handling → Find Toolbar
Product: Core → Toolkit

(In reply to Olli Pettay [:smaug] from comment #3)

Do you have "Search for text when you start typing" enabled in the preferences?

I can't reproduce using Finnish keyboard layout (" is shift+2)

"Search for text when you start typing" is not enabled in the preferences.
I'm not surprised that alternative keyboard layouts produce different results, as this particular html assumes a standard US keyboard layout, as it is attempting to somewhat emulate a music (e.g., piano) keyboard and needs to know the physical position of the keys.

Yes, a single quote summons the links-only quickfind bar. Re-engineering this feature to detect if page Javascript is doing anything with the key is likely more work than this is worth, but we could add a pref to control the behaviour.

Severity: -- → S4
Priority: -- → P3
Summary: holding down single quote opens Find → Add a pref to disable quickfind bar
You need to log in before you can comment on or make changes to this bug.