1702409 - [wpt-sync] Sync PR 28331 - Revert "Relax constraints on scroll snapping for snap-type both."

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28331 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28331
Details from upstream follow.

b'Noel Gordon <[e-mail]>' wrote:

Revert "Relax constraints on scroll snapping for snap-type both."

This reverts commit 9f51ed46d53717149e7496dbd7baf0eb372c046a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 868394 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlmNTFlZDQ2ZDUzNzE3MTQ5ZTc0OTZkYmQ3YmFmMGViMzcyYzA0NmEM

Original change's description:

Relax constraints on scroll snapping for snap-type both.

Our scroll snapping logic confined the snap position to be within
the visible snapport if snapping in both the x and y direction; however,
snaps are allowed to be outside the "snapport's search corridor" as long
as they are not too far outside (left to the user agent to determine
what constitutes "too far"). The relaxed rules are not applied if
snapping in one direction only, or if scroll-snap-stop is set to
'always'.

In addressing the issue, two other tests required tweaking since they
had no allowance for a 2D snap outside the visible snapport either
implicitly (nested-scrollIntoView-snaps.html) or explicitly
(scroll_snap_data_unittest.cc).

Bug: 626703
Change-Id: I3646ccc271d88e06f3e6655009e32ff2a9e08931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785142
Reviewed-by: Robert Flack \<[e-mail]>
Commit-Queue: Kevin Ellis \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#868394}

Bug: 626703
Change-Id: I760ad79c204f0f3dc7d73a5fd721b1bf91a2d827
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798148
Bot-Commit: Rubber Stamper \<[e-mail]>
Owners-Override: Noel Gordon \<[e-mail]>
Auto-Submit: Noel Gordon \<[e-mail]>
Commit-Queue: Noel Gordon \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#868436}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b24f51bebb03adbcc6d1641700a6fb9e37574549

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7af668e77605
[wpt PR 28331] - Revert "Relax constraints on scroll snapping for snap-type both.", a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/728b070609ec
[wpt PR 28331] - Revert "Relax constraints on scroll snapping for snap-type both.", a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e15687c3b52
[wpt PR 28331] - Revert "Relax constraints on scroll snapping for snap-type both.", a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89d3d5702bdc
[wpt PR 28331] - Revert "Relax constraints on scroll snapping for snap-type both.", a=testonly

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/89d3d5702bdc