[meta] Monitor and fix QM_TRY failures
Categories
(Core :: Storage: Quota Manager, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox103 | --- | affected |
People
(Reporter: jstutte, Unassigned)
References
(Depends on 81 open bugs, Blocks 1 open bug)
Details
(Keywords: leave-open, meta)
Attachments
(216 files, 6 obsolete files)
116.06 KB,
text/plain
|
Details | |
116.86 KB,
text/plain
|
Details | |
110.31 KB,
text/plain
|
Details | |
782.87 KB,
text/plain
|
Details | |
305.88 KB,
text/plain
|
Details | |
117.73 KB,
text/plain
|
Details | |
338.07 KB,
text/plain
|
Details | |
716.32 KB,
text/plain
|
Details | |
286.01 KB,
text/plain
|
Details | |
874.06 KB,
text/plain
|
Details | |
1.14 MB,
text/plain
|
Details | |
521.14 KB,
text/plain
|
Details | |
744.07 KB,
text/plain
|
Details | |
331.61 KB,
text/plain
|
Details | |
516.26 KB,
text/plain
|
Details | |
700.63 KB,
text/plain
|
Details | |
78.46 KB,
text/plain
|
Details | |
328.25 KB,
text/plain
|
Details | |
542.68 KB,
text/plain
|
Details | |
145.74 KB,
text/plain
|
Details | |
199.02 KB,
text/plain
|
Details | |
271.92 KB,
text/plain
|
Details | |
673.53 KB,
text/plain
|
Details | |
623.17 KB,
text/plain
|
Details | |
109.63 KB,
text/plain
|
Details | |
187.56 KB,
text/plain
|
Details | |
445.51 KB,
text/plain
|
Details | |
372.25 KB,
text/plain
|
Details | |
239.00 KB,
text/plain
|
Details | |
198.69 KB,
text/plain
|
Details | |
302.08 KB,
text/plain
|
Details | |
295.57 KB,
text/plain
|
Details | |
286.59 KB,
text/plain
|
Details | |
331.08 KB,
text/plain
|
Details | |
343.21 KB,
text/plain
|
Details | |
232.02 KB,
text/plain
|
Details | |
337.49 KB,
text/plain
|
Details | |
269.75 KB,
text/plain
|
Details | |
227.49 KB,
text/plain
|
Details | |
290.43 KB,
text/plain
|
Details | |
216.24 KB,
text/plain
|
Details | |
202.91 KB,
text/plain
|
Details | |
263.84 KB,
text/plain
|
Details | |
244.26 KB,
text/plain
|
Details | |
300.69 KB,
text/plain
|
Details | |
183.95 KB,
text/plain
|
Details | |
256.48 KB,
text/plain
|
Details | |
254.54 KB,
text/plain
|
Details | |
255.46 KB,
text/plain
|
Details | |
268.95 KB,
text/plain
|
Details | |
268.71 KB,
text/plain
|
Details | |
254.23 KB,
text/plain
|
Details | |
215.82 KB,
text/plain
|
Details | |
260.59 KB,
text/plain
|
Details | |
303.54 KB,
text/plain
|
Details | |
282.22 KB,
text/plain
|
Details | |
307.29 KB,
text/plain
|
Details | |
245.98 KB,
text/plain
|
Details | |
258.29 KB,
text/plain
|
Details | |
209.74 KB,
text/plain
|
Details | |
255.44 KB,
text/plain
|
Details | |
209.12 KB,
text/plain
|
Details | |
232.11 KB,
text/plain
|
Details | |
246.86 KB,
text/plain
|
Details | |
302.73 KB,
text/plain
|
Details | |
184.32 KB,
text/plain
|
Details | |
373.34 KB,
text/plain
|
Details | |
377.56 KB,
text/plain
|
Details | |
275.12 KB,
text/plain
|
Details | |
276.36 KB,
text/plain
|
Details | |
282.32 KB,
text/plain
|
Details | |
323.73 KB,
text/plain
|
Details | |
286.96 KB,
text/plain
|
Details | |
325.39 KB,
text/plain
|
Details | |
274.51 KB,
text/plain
|
Details | |
340.96 KB,
text/plain
|
Details | |
341.21 KB,
text/plain
|
Details | |
433.82 KB,
text/plain
|
Details | |
319.63 KB,
text/plain
|
Details | |
349.31 KB,
text/plain
|
Details | |
285.41 KB,
text/plain
|
Details | |
412.60 KB,
text/plain
|
Details | |
307.48 KB,
text/plain
|
Details | |
284.58 KB,
text/plain
|
Details | |
267.15 KB,
text/plain
|
Details | |
317.80 KB,
text/plain
|
Details | |
247.40 KB,
text/plain
|
Details | |
262.19 KB,
text/plain
|
Details | |
279.78 KB,
text/plain
|
Details | |
276.19 KB,
text/plain
|
Details | |
270.99 KB,
text/plain
|
Details | |
288.98 KB,
text/plain
|
Details | |
277.55 KB,
text/plain
|
Details | |
268.15 KB,
text/plain
|
Details | |
260.38 KB,
text/plain
|
Details | |
258.75 KB,
text/plain
|
Details | |
228.23 KB,
text/plain
|
Details | |
248.97 KB,
text/plain
|
Details | |
230.88 KB,
text/plain
|
Details | |
297.71 KB,
text/plain
|
Details | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
254.26 KB,
text/plain
|
Details | |
247.42 KB,
text/plain
|
Details | |
298.59 KB,
text/plain
|
Details | |
300.09 KB,
text/plain
|
Details | |
286.41 KB,
text/plain
|
Details | |
247.84 KB,
text/plain
|
Details | |
235.36 KB,
text/plain
|
Details | |
348.40 KB,
text/plain
|
Details | |
238.59 KB,
text/plain
|
Details | |
303.47 KB,
text/plain
|
Details | |
304.32 KB,
text/plain
|
Details | |
310.83 KB,
text/plain
|
Details | |
362.37 KB,
text/plain
|
Details | |
279.26 KB,
text/plain
|
Details | |
249.87 KB,
text/plain
|
Details | |
300.43 KB,
text/plain
|
Details | |
395.53 KB,
text/plain
|
Details | |
254.79 KB,
text/plain
|
Details | |
289.73 KB,
text/plain
|
Details | |
884.05 KB,
text/plain
|
Details | |
264.39 KB,
text/plain
|
Details | |
274.68 KB,
text/plain
|
Details | |
269.90 KB,
text/plain
|
Details | |
284.04 KB,
text/plain
|
Details | |
263.35 KB,
text/plain
|
Details | |
309.45 KB,
text/plain
|
Details | |
279.44 KB,
text/plain
|
Details | |
314.55 KB,
text/plain
|
Details | |
328.00 KB,
text/plain
|
Details | |
223.62 KB,
text/plain
|
Details | |
298.52 KB,
text/plain
|
Details | |
265.16 KB,
text/plain
|
Details | |
324.87 KB,
text/plain
|
Details | |
275.77 KB,
text/plain
|
Details | |
323.18 KB,
text/plain
|
Details | |
298.36 KB,
text/plain
|
Details | |
302.86 KB,
text/plain
|
Details | |
294.30 KB,
text/plain
|
Details | |
280.29 KB,
text/plain
|
Details | |
268.99 KB,
text/plain
|
Details | |
273.30 KB,
text/plain
|
Details | |
242.67 KB,
text/plain
|
Details | |
256.37 KB,
text/plain
|
Details | |
342.72 KB,
text/plain
|
Details | |
227.26 KB,
text/plain
|
Details | |
271.83 KB,
text/plain
|
Details | |
212.70 KB,
text/plain
|
Details | |
257.28 KB,
text/plain
|
Details | |
309.30 KB,
text/plain
|
Details | |
289.45 KB,
text/plain
|
Details | |
233.23 KB,
text/plain
|
Details | |
340.76 KB,
text/plain
|
Details | |
277.63 KB,
text/plain
|
Details | |
272.79 KB,
text/plain
|
Details | |
253.63 KB,
text/plain
|
Details | |
256.35 KB,
text/plain
|
Details | |
340.04 KB,
text/plain
|
Details | |
293.59 KB,
text/plain
|
Details | |
231.88 KB,
text/plain
|
Details | |
272.07 KB,
text/plain
|
Details | |
299.02 KB,
text/plain
|
Details | |
353.89 KB,
text/plain
|
Details | |
293.04 KB,
text/plain
|
Details | |
344.22 KB,
text/plain
|
Details | |
320.00 KB,
text/plain
|
Details | |
286.38 KB,
text/plain
|
Details | |
280.35 KB,
text/plain
|
Details | |
391.13 KB,
text/plain
|
Details | |
367.10 KB,
text/plain
|
Details | |
392.94 KB,
text/plain
|
Details | |
400.49 KB,
text/plain
|
Details | |
345.41 KB,
text/plain
|
Details | |
384.25 KB,
text/plain
|
Details | |
305.98 KB,
text/plain
|
Details | |
406.65 KB,
text/plain
|
Details | |
339.48 KB,
text/plain
|
Details | |
354.13 KB,
text/plain
|
Details | |
260.15 KB,
text/plain
|
Details | |
413.08 KB,
text/plain
|
Details | |
270.03 KB,
text/plain
|
Details | |
337.35 KB,
text/plain
|
Details | |
280.80 KB,
text/plain
|
Details | |
299.49 KB,
text/plain
|
Details | |
297.21 KB,
text/plain
|
Details | |
279.70 KB,
text/plain
|
Details | |
249.76 KB,
text/plain
|
Details | |
342.80 KB,
text/plain
|
Details | |
1.50 MB,
text/plain
|
Details | |
272.96 KB,
text/plain
|
Details | |
346.09 KB,
text/plain
|
Details | |
270.63 KB,
text/plain
|
Details | |
367.62 KB,
text/plain
|
Details | |
606.11 KB,
text/plain
|
Details | |
371.68 KB,
text/plain
|
Details | |
347.79 KB,
text/plain
|
Details | |
459.53 KB,
text/plain
|
Details | |
323.17 KB,
text/plain
|
Details | |
377.44 KB,
text/plain
|
Details | |
381.74 KB,
text/plain
|
Details | |
377.04 KB,
text/plain
|
Details | |
445.53 KB,
text/plain
|
Details | |
325.53 KB,
text/plain
|
Details | |
309.06 KB,
text/plain
|
Details | |
251.45 KB,
text/plain
|
Details | |
254.20 KB,
text/plain
|
Details | |
277.03 KB,
text/plain
|
Details | |
231.80 KB,
text/plain
|
Details | |
246.50 KB,
text/plain
|
Details | |
129.87 KB,
text/plain
|
Details | |
232.16 KB,
text/plain
|
Details | |
210.66 KB,
text/plain
|
Details | |
230.85 KB,
text/plain
|
Details | |
172.12 KB,
text/plain
|
Details | |
258.39 KB,
text/plain
|
Details | |
256.65 KB,
text/plain
|
Details |
This bugs keeps track of the semi-automatic monitoring of QM_TRY failures.
Specific bugs will be filed underneath.
Reporter | ||
Comment 1•3 years ago
|
||
Reporter | ||
Comment 2•3 years ago
|
||
Reporter | ||
Comment 3•3 years ago
|
||
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 4•3 years ago
|
||
Reporter | ||
Comment 5•3 years ago
|
||
:janv, I am a bit puzzled to see QM_TRY_INSPECT as a function name here?
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
5 | 5 | 5 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | dom/quota/ActorsParent.cpp#667:None <- dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED |
3 | 3 | 3 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | dom/quota/ActorsParent.cpp#667:None <- dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED |
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | dom/quota/ActorsParent.cpp#2399:WIN32(0x570) <- dom/quota/ActorsParent.cpp#4647:WIN32(0x570) <- dom/quota/ActorsParent.cpp#4230:WIN32(0x570) <- dom/quota/ActorsParent.cpp#4233:WIN32(0x570) <- dom/quota/ActorsParent.cpp#6234:WIN32(0x570) |
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | dom/quota/ActorsParent.cpp#2399:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4647:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4230:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4233:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#6234:NS_ERROR_FILE_ACCESS_DENIED |
Comment 6•3 years ago
|
||
My first guess is that rust-code-analysis-cli
is confused by the macro in some places. I would need to see the metrics file to tell more. Should I try myself ?
Comment 7•3 years ago
|
||
Or maybe the script needs a list of functions that should be ignored (if QM_TRY is considered as a function) and use other function name which is not the closest one.
Reporter | ||
Comment 8•3 years ago
•
|
||
(In reply to Jan Varga [:janv] from comment #6)
My first guess is that
rust-code-analysis-cli
is confused by the macro in some places. I would need to see the metrics file to tell more. Should I try myself ?
This seems to be the case. Fetching ActorsParent.cpp manually and applying rust-code-analysis-cli -m -O json -o /tmp -p /tmp/ActorsParent.cpp
manually yields:
...
{
"name": "LoadLocalStorageArchiveVersion",
"start_line": 658,
"end_line": 755,
"kind": "function",
"spaces": [
{
"name": "QM_TRY_INSPECT",
"start_line": 662,
"end_line": 745,
"kind": "function",
"spaces": [],
"metrics": {
"nargs": {
"sum": 7.0,
"average": 7.0
},
"nexits": {
"sum": 0.0,
"average": 0.0
},
"cognitive": {
"sum": 0.0,
"average": 0.0
},
"cyclomatic": {
"sum": 7.0,
"average": 7.0
},
"halstead": {
"n1": 19.0,
"N1": 157.0,
"n2": 65.0,
"N2": 119.0,
"length": 276.0,
"estimated_program_length": 472.16453060227764,
"purity_ratio": 1.710741052906803,
"vocabulary": 84.0,
"volume": 1764.279608686938,
"difficulty": 17.392307692307693,
"level": 0.05749668288367979,
"effort": 30684.893809547437,
"time": 1704.7163227526353,
"bugs": 0.32670954919749584
},
"loc": {
"sloc": 84.0,
"ploc": 60.0,
"lloc": 1.0,
"cloc": 5.0,
"blank": 19.0
},
"nom": {
"functions": 1.0,
"closures": 0.0,
"total": 1.0
},
"mi": {
"mi_original": 58.738179650614256,
"mi_sei": 28.20463653446185,
"mi_visual_studio": 34.34981266117793
}
}
},
{
"name": "~Observer",
"start_line": 747,
"end_line": 747,
"kind": "function",
"spaces": [],
"metrics": {
"nargs": {
"sum": 0.0,
"average": 0.0
},
"nexits": {
"sum": 0.0,
"average": 0.0
},
"cognitive": {
"sum": 0.0,
"average": 0.0
},
"cyclomatic": {
"sum": 1.0,
"average": 1.0
},
"halstead": {
"n1": 4.0,
"N1": 6.0,
"n2": 3.0,
"N2": 3.0,
"length": 9.0,
"estimated_program_length": 12.754887502163468,
"purity_ratio": 1.4172097224626077,
"vocabulary": 7.0,
"volume": 25.26619429851844,
"difficulty": 2.0,
"level": 0.5,
"effort": 50.53238859703688,
"time": 2.807354922057604,
"bugs": 0.004556086527391188
},
"loc": {
"sloc": 1.0,
"ploc": 1.0,
"lloc": 1.0,
"cloc": 0.0,
"blank": 0.0
},
"nom": {
"functions": 1.0,
"closures": 0.0,
"total": 1.0
},
"mi": {
"mi_original": 153.97676999581998,
"mi_sei": 146.54249035246173,
"mi_visual_studio": 90.04489473439764
}
}
}
],
"metrics": {
"nargs": {
"sum": 8.0,
"average": 2.6666666666666665
},
"nexits": {
"sum": 0.0,
"average": 0.0
},
"cognitive": {
"sum": 0.0,
"average": 0.0
},
"cyclomatic": {
"sum": 9.0,
"average": 3.0
},
"halstead": {
"n1": 20.0,
"N1": 176.0,
"n2": 68.0,
"N2": 132.0,
"length": 308.0,
"estimated_program_length": 500.38603510277034,
"purity_ratio": 1.6246299840999037,
"vocabulary": 88.0,
"volume": 1989.5049385402876,
"difficulty": 19.41176470588235,
"level": 0.05151515151515152,
"effort": 38619.80174813499,
"time": 2145.5445415630547,
"bugs": 0.3808483736064195
},
"loc": {
"sloc": 98.0,
"ploc": 69.0,
"lloc": 3.0,
"cloc": 5.0,
"blank": 24.0
},
"nom": {
"functions": 3.0,
"closures": 0.0,
"total": 3.0
},
"mi": {
"mi_original": 55.15619306227286,
"mi_sei": 21.9305595486369,
"mi_visual_studio": 32.25508366214787
}
}
},
...
The line numbers are clearly wrong here. And similar problems are happening also in other places around QM_TRY_INSPECT. As the line numbers also of LoadLocalStorageArchiveVersion
itself are wrong (end line), I fear that ignoring QM_* function names might not always help.
:marco, is this something you ever noticed in rust-code-analysis-cli
?
Comment 9•3 years ago
|
||
Is there a way to get rust-code-analysis to dump the tree-sitter AST/parse? I presume there's an error node in the given method that causes it to miss the end of the function and eat further.
Comment 10•3 years ago
|
||
:asuth, yes it's possible:
cargo run -p rust-code-analysis-cli -- -p /tmp/ActorsParent.cpp -d --ls 658 --le 671
ls
and le
are here to limit the ast dump to nodes which are between these two line numbers (included).
and the problem is because of
QM_TRY_INSPECT(const auto& stmt, ...
because it isn't really grammatically correct.
In rca we've a grammar for mozilla-central code:
https://github.com/mozilla/rust-code-analysis/blob/master/tree-sitter-mozcpp/grammar.js
so we can amend it to handle special cases (it's the goal of this grammar), feel free to file a bug.
Comment 11•3 years ago
|
||
I wrote a patch for rca to fix the problem:
https://github.com/mozilla/rust-code-analysis/pull/611
Reporter | ||
Comment 12•3 years ago
|
||
(In reply to Calixte Denizet (:calixte) from comment #11)
I wrote a patch for rca to fix the problem:
https://github.com/mozilla/rust-code-analysis/pull/611
Thanks a lot!
Reporter | ||
Comment 13•3 years ago
|
||
It works:
< 5 | 5 | 5 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | [dom/quota/ActorsParent.cpp#667:None](https://hg.mozilla.org/releases/mozilla-beta/annotate/276ecc030f1c341ecf57287999ff4bec10adfb4f/dom/quota/ActorsParent.cpp#l667) <- [dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED](https://hg.mozilla.org/releases/mozilla-beta/annotate/276ecc030f1c341ecf57287999ff4bec10adfb4f/dom/quota/ActorsParent.cpp#l5875)
---
> 5 | 5 | 5 | dom/quota/ActorsParent.cpp:LoadLocalStorageArchiveVersion | [dom/quota/ActorsParent.cpp#667:None](https://hg.mozilla.org/releases/mozilla-beta/annotate/276ecc030f1c341ecf57287999ff4bec10adfb4f/dom/quota/ActorsParent.cpp#l667) <- [dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED](https://hg.mozilla.org/releases/mozilla-beta/annotate/276ecc030f1c341ecf57287999ff4bec10adfb4f/dom/quota/ActorsParent.cpp#l5875)
Thanks!
Reporter | ||
Comment 14•3 years ago
|
||
Reporter | ||
Comment 15•3 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
2 | 2 | 2 | dom/quota/ActorsParent.cpp:LoadLocalStorageArchiveVersion | dom/quota/ActorsParent.cpp#667:None <- dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED |
Reporter | ||
Comment 16•3 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
2 | 2 | 2 | dom/quota/ActorsParent.cpp:QuotaManager::EnsureStorageIsInitialized | dom/quota/ActorsParent.cpp#6011:NS_ERROR_FILE_ACCESS_DENIED |
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QuotaManager::EnsureStorageIsInitialized | dom/quota/ActorsParent.cpp#6011:NS_ERROR_STORAGE_BUSY |
Reporter | ||
Comment 17•3 years ago
|
||
Needs new bug:
Reporter | ||
Comment 18•3 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/quota/ActorsParent.cpp:MaybeUpdateGroupForOrigin | dom/quota/ActorsParent.cpp#1829:NS_ERROR_MALFORMED_URI <- dom/quota/ActorsParent.cpp#4596:NS_ERROR_MALFORMED_URI <- dom/quota/ActorsParent.cpp#4628:NS_ERROR_MALFORMED_URI |
Reporter | ||
Comment 19•3 years ago
|
||
Needs new bug:
Reporter | ||
Comment 20•3 years ago
|
||
Needs new bug:
Reporter | ||
Comment 21•3 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 2 | 2 | dom/quota/ActorsParent.cpp:QuotaManager::CopyLocalStorageArchiveFromWebAppsStore | dom/quota/ActorsParent.cpp#5514:WIN32(0x570) <- dom/quota/ActorsParent.cpp#5859:WIN32(0x570) <- dom/quota/ActorsParent.cpp#5863:WIN32(0x570) <- dom/quota/ActorsParent.cpp#6041:WIN32(0x570) |
Reporter | ||
Comment 22•3 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/quota/QuotaCommon.cpp:ExecuteSingleStep | dom/quota/QuotaCommon.cpp#201:NS_ERROR_OUT_OF_MEMORY <- dom/quota/ActorsParent.cpp#665:NS_ERROR_OUT_OF_MEMORY <- dom/quota/ActorsParent.cpp#5875:NS_ERROR_OUT_OF_MEMORY <- dom/quota/ActorsParent.cpp#6041:NS_ERROR_OUT_OF_MEMORY |
Reporter | ||
Comment 23•3 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpdateUsageFile | dom/localstorage/ActorsParent.cpp#1000:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8123:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8129:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8137:NS_ERROR_FILE_IS_LOCKED <- dom/quota/ActorsParent.cpp#4867:NS_ERROR_FILE_IS_LOCKED <- dom/quota/ActorsParent.cpp#4939:NS_ERROR_FILE_IS_LOCKED |
1 | 1 | 2 | dom/localstorage/ActorsParent.cpp:UpdateUsageFile | dom/localstorage/ActorsParent.cpp#1000:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8123:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8129:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8137:NS_ERROR_FILE_IS_LOCKED <- dom/quota/ActorsParent.cpp#4867:NS_ERROR_FILE_IS_LOCKED <- dom/quota/ActorsParent.cpp#4939:NS_ERROR_FILE_IS_LOCKED |
Reporter | ||
Comment 24•3 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QuotaManager::MaybeCreateOrUpgradeStorage | dom/quota/ActorsParent.cpp#5811:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#6013:NS_ERROR_FILE_NO_DEVICE_SPACE |
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QuotaManager::MaybeCreateOrUpgradeStorage | dom/quota/ActorsParent.cpp#5811:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#6013:NS_ERROR_FILE_NO_DEVICE_SPACE |
Reporter | ||
Comment 25•3 years ago
|
||
Reporter | ||
Comment 26•3 years ago
|
||
Reporter | ||
Comment 27•3 years ago
|
||
Reporter | ||
Comment 28•3 years ago
|
||
Reporter | ||
Comment 29•3 years ago
|
||
The last two files are almost a week old, I will not file the single errors.
Reporter | ||
Comment 30•3 years ago
|
||
Reporter | ||
Comment 31•3 years ago
|
||
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 32•3 years ago
|
||
Hopefully better split with less false errors.
Reporter | ||
Comment 33•3 years ago
|
||
Also here, hopefully better split with less false alarms.
Reporter | ||
Comment 34•3 years ago
|
||
Reporter | ||
Comment 35•3 years ago
|
||
Reporter | ||
Comment 36•3 years ago
|
||
Reporter | ||
Comment 37•3 years ago
|
||
Reporter | ||
Comment 38•3 years ago
|
||
Reporter | ||
Comment 39•3 years ago
|
||
Reporter | ||
Comment 40•3 years ago
|
||
Reporter | ||
Comment 41•3 years ago
|
||
Reporter | ||
Comment 42•3 years ago
|
||
Reporter | ||
Comment 43•3 years ago
|
||
Reporter | ||
Comment 44•3 years ago
|
||
Reporter | ||
Comment 45•3 years ago
•
|
||
Looking at the frequency of different stacks with nsResult:
Errors:
> cat qmerrors_until_1622505580053.json | grep result | sort | uniq -c
166 "result": "NS_ERROR_FILE_ACCESS_DENIED",
25 "result": "NS_ERROR_FILE_DIR_NOT_EMPTY",
18 "result": "NS_ERROR_FILE_FS_CORRUPTED",
10 "result": "NS_ERROR_FILE_IS_LOCKED",
3 "result": "NS_ERROR_FILE_NO_DEVICE_SPACE",
50 "result": "NS_ERROR_FILE_NOT_FOUND",
3 "result": "NS_ERROR_FILE_READ_ONLY",
4 "result": null,
Warnings:
> cat qmwarnings_until_1622505580053.json | grep result | sort | uniq -c
65 "result": "NS_ERROR_FAILURE",
27 "result": "NS_ERROR_FILE_ACCESS_DENIED",
15 "result": "NS_ERROR_FILE_CORRUPTED",
3 "result": "NS_ERROR_FILE_DEVICE_FAILURE",
1 "result": "NS_ERROR_FILE_DIR_NOT_EMPTY",
9 "result": "NS_ERROR_FILE_IS_LOCKED",
1 "result": "NS_ERROR_FILE_NO_DEVICE_SPACE",
108 "result": "NS_ERROR_FILE_NOT_FOUND",
2 "result": "NS_ERROR_FILE_READ_ONLY",
45 "result": "NS_ERROR_FILE_TARGET_DOES_NOT_EXIST",
6 "result": "NS_ERROR_FILE_TOO_BIG",
44 "result": "NS_ERROR_ILLEGAL_VALUE",
6 "result": "NS_ERROR_MALFORMED_URI",
7 "result": "NS_ERROR_STORAGE_IOERR",
6 "result": "NS_ERROR_UNEXPECTED",
55 "result": null,
Please note, that this does not count, how often those stacks occur, it is just the number of unique stack frames in this script run (we could do better but not with a 5min bash line).
Things worth an investigation:
Error | Comment |
---|---|
NS_ERROR_FILE_DEVICE_FAILURE | Should never be a Warning? |
NS_ERROR_FILE_NO_DEVICE_SPACE | Should never be a Warning? |
NS_ERROR_FAILURE | See bug 1712582 |
NS_ERROR_UNEXPECTED | Unspecific? |
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 46•3 years ago
|
||
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 47•3 years ago
|
||
Reporter | ||
Comment 48•3 years ago
|
||
Reporter | ||
Comment 49•3 years ago
|
||
Reporter | ||
Comment 50•3 years ago
|
||
Reporter | ||
Comment 51•3 years ago
|
||
Reporter | ||
Comment 52•3 years ago
|
||
Reporter | ||
Comment 53•3 years ago
|
||
Reporter | ||
Comment 54•3 years ago
|
||
Reporter | ||
Comment 55•3 years ago
|
||
Reporter | ||
Comment 56•3 years ago
|
||
Reporter | ||
Comment 57•3 years ago
|
||
Reporter | ||
Comment 58•3 years ago
|
||
Reporter | ||
Comment 59•3 years ago
|
||
New entries (bugs to file):
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:PrepareDatastoreOp::VerifyDatabaseInformation | dom/localstorage/ActorsParent.cpp#7129:None <- dom/localstorage/ActorsParent.cpp#6940:NS_ERROR_FILE_CORRUPTED |
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/quota/ActorsParent.cpp:GetLastModifiedTime | dom/quota/ActorsParent.cpp#2356:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#2337:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#2340:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#2337:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#2340:NS_ERROR_FILE_FS_CORRUPTED |
Reporter | ||
Comment 60•3 years ago
|
||
Reporter | ||
Comment 61•3 years ago
|
||
Comment 62•3 years ago
|
||
Reporter | ||
Updated•3 years ago
|
Comment 63•3 years ago
|
||
Comment 64•3 years ago
|
||
Comment 65•3 years ago
|
||
Comment 66•3 years ago
|
||
Comment 67•3 years ago
|
||
Comment 68•3 years ago
|
||
Comment 69•3 years ago
|
||
Comment 70•3 years ago
|
||
Comment 71•3 years ago
|
||
Comment 72•3 years ago
|
||
Comment 73•3 years ago
|
||
Comment 74•3 years ago
|
||
Comment 75•3 years ago
|
||
Comment 76•3 years ago
|
||
Comment 77•3 years ago
|
||
Comment 78•3 years ago
|
||
Comment 79•3 years ago
|
||
Comment 80•3 years ago
|
||
Comment 81•3 years ago
|
||
Comment 82•3 years ago
|
||
Comment 83•3 years ago
|
||
Comment 84•3 years ago
|
||
Comment 85•3 years ago
|
||
Comment 86•3 years ago
|
||
Comment 87•2 years ago
|
||
Comment 88•2 years ago
|
||
Comment 89•2 years ago
|
||
Comment 90•2 years ago
|
||
Comment 91•2 years ago
|
||
Comment 92•2 years ago
|
||
Comment 93•2 years ago
|
||
Comment 94•2 years ago
|
||
Comment 95•2 years ago
|
||
Comment 96•2 years ago
|
||
Comment 97•2 years ago
|
||
Comment 98•2 years ago
|
||
Comment 99•2 years ago
|
||
Comment 100•2 years ago
|
||
Comment 101•2 years ago
|
||
Comment 102•2 years ago
|
||
Comment 103•2 years ago
|
||
Comment 104•2 years ago
|
||
Comment 105•2 years ago
|
||
Comment 106•2 years ago
|
||
Comment 107•2 years ago
|
||
Comment 108•2 years ago
|
||
Comment 109•2 years ago
|
||
Comment 110•2 years ago
|
||
Comment 111•2 years ago
|
||
Comment 112•2 years ago
|
||
Comment 113•2 years ago
|
||
Comment 114•2 years ago
|
||
Comment 115•2 years ago
|
||
Comment 116•2 years ago
|
||
Comment 117•2 years ago
|
||
Comment 118•2 years ago
|
||
Comment 119•2 years ago
|
||
The rust-code-analysis-cli
had to be run again because previously mostly unknown anchors were returned.
Comment 120•2 years ago
|
||
Comment 121•2 years ago
|
||
Comment 122•2 years ago
|
||
Comment 123•2 years ago
|
||
Comment 124•2 years ago
|
||
Comment 125•2 years ago
|
||
Comment 126•2 years ago
|
||
Comment 127•2 years ago
|
||
Comment 128•2 years ago
|
||
Comment 129•2 years ago
|
||
Comment 130•2 years ago
|
||
Comment 131•2 years ago
|
||
Pushed by jkrause@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13c0b769cc03 Add `context` to Bugzilla comment markup. r=jstutte,dom-storage-reviewers
Comment 132•2 years ago
|
||
bugherder |
Reporter | ||
Comment 133•2 years ago
|
||
The closure was not intended here, this is a perennial thing.
Comment 134•2 years ago
|
||
Updated•2 years ago
|
Comment 135•2 years ago
|
||
Comment 136•2 years ago
|
||
Comment 137•2 years ago
|
||
Comment 138•2 years ago
|
||
Comment 139•2 years ago
|
||
Comment 140•2 years ago
|
||
Comment 141•2 years ago
|
||
Comment 142•2 years ago
|
||
Comment 143•2 years ago
|
||
Comment 144•2 years ago
|
||
Comment 145•2 years ago
|
||
Comment 146•2 years ago
|
||
Comment 147•2 years ago
|
||
Comment 148•2 years ago
|
||
Comment 149•2 years ago
|
||
Comment 150•2 years ago
|
||
Comment 151•2 years ago
|
||
Comment 152•2 years ago
|
||
Comment 153•2 years ago
|
||
Comment 154•2 years ago
|
||
Comment 155•2 years ago
|
||
Comment 156•2 years ago
|
||
Comment 157•2 years ago
|
||
Comment 158•2 years ago
|
||
Comment 159•2 years ago
|
||
Comment 160•2 years ago
|
||
Comment 161•2 years ago
|
||
Comment 162•2 years ago
|
||
Comment 163•2 years ago
|
||
Comment 164•2 years ago
|
||
Comment 165•2 years ago
|
||
Comment 166•2 years ago
|
||
Comment 167•1 year ago
|
||
Comment 168•1 year ago
|
||
Comment 169•1 year ago
|
||
Comment 170•1 year ago
|
||
Comment 171•1 year ago
|
||
Comment 172•1 year ago
|
||
Comment 173•1 year ago
|
||
Comment 174•1 year ago
|
||
Comment 175•1 year ago
|
||
Comment 176•1 year ago
|
||
Comment 177•1 year ago
|
||
Comment 178•1 year ago
|
||
Comment 179•1 year ago
|
||
Comment 180•1 year ago
|
||
Comment 181•1 year ago
|
||
Comment 182•1 year ago
|
||
Comment 183•1 year ago
|
||
Comment 184•1 year ago
|
||
Comment 185•1 year ago
|
||
Comment 186•1 year ago
|
||
Comment 187•1 year ago
|
||
Comment 188•1 year ago
|
||
Comment 189•1 year ago
|
||
Comment 190•1 year ago
|
||
Comment 191•1 year ago
|
||
Comment 192•1 year ago
|
||
Comment 193•1 year ago
|
||
Comment 194•1 year ago
|
||
Comment 195•1 year ago
|
||
Comment 196•1 year ago
|
||
Comment 197•1 year ago
|
||
Comment 198•1 year ago
|
||
Comment 199•1 year ago
|
||
Comment 200•1 year ago
|
||
Comment 201•1 year ago
|
||
Comment 202•1 year ago
|
||
Comment 203•1 year ago
|
||
Comment 204•1 year ago
|
||
Comment 205•1 year ago
|
||
Comment 206•11 months ago
|
||
Comment 207•11 months ago
|
||
Comment 208•11 months ago
|
||
Comment 209•11 months ago
|
||
Comment 210•11 months ago
|
||
Comment 211•11 months ago
|
||
Comment 212•11 months ago
|
||
Comment 213•10 months ago
|
||
Comment 214•10 months ago
|
||
Comment 215•10 months ago
|
||
Comment 216•10 months ago
|
||
Comment 217•10 months ago
|
||
Comment 218•10 months ago
|
||
Comment 219•10 months ago
|
||
Comment 220•9 months ago
|
||
Comment 221•9 months ago
|
||
Comment 222•9 months ago
|
||
Comment 223•9 months ago
|
||
Comment 224•9 months ago
|
||
Reporter | ||
Comment 225•7 months ago
|
||
Comment 226•6 months ago
|
||
Comment 227•6 months ago
|
||
Updated•6 months ago
|
Comment 228•6 months ago
|
||
Comment 229•6 months ago
|
||
Comment 230•6 months ago
|
||
Comment 231•5 months ago
|
||
Updated•5 months ago
|
Comment 232•5 months ago
|
||
Comment 233•4 months ago
|
||
Comment 234•4 months ago
|
||
Comment 235•3 months ago
|
||
Comment 236•3 months ago
|
||
Comment 237•3 months ago
|
||
Comment 238•3 months ago
|
||
Comment 239•3 months ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Comment 240•2 months ago
|
||
Comment 241•2 months ago
|
||
Comment 242•2 months ago
|
||
Comment 243•2 months ago
|
||
Comment 244•1 month ago
|
||
Comment 245•1 month ago
|
||
Comment 246•24 days ago
|
||
Comment 247•17 days ago
|
||
Comment 248•10 days ago
|
||
Comment 249•3 days ago
|
||
Description
•