[meta] Monitor and fix QM_TRY failures
Categories
(Core :: Storage: Quota Manager, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox103 | --- | affected |
People
(Reporter: jstutte, Assigned: jkrause)
References
(Depends on 75 open bugs, Blocks 1 open bug)
Details
(Keywords: leave-open, meta)
Attachments
(165 files, 5 obsolete files)
116.06 KB,
text/plain
|
Details | |
116.86 KB,
text/plain
|
Details | |
110.31 KB,
text/plain
|
Details | |
782.87 KB,
text/plain
|
Details | |
305.88 KB,
text/plain
|
Details | |
117.73 KB,
text/plain
|
Details | |
338.07 KB,
text/plain
|
Details | |
716.32 KB,
text/plain
|
Details | |
286.01 KB,
text/plain
|
Details | |
874.06 KB,
text/plain
|
Details | |
1.14 MB,
text/plain
|
Details | |
521.14 KB,
text/plain
|
Details | |
744.07 KB,
text/plain
|
Details | |
331.61 KB,
text/plain
|
Details | |
516.26 KB,
text/plain
|
Details | |
700.63 KB,
text/plain
|
Details | |
78.46 KB,
text/plain
|
Details | |
328.25 KB,
text/plain
|
Details | |
542.68 KB,
text/plain
|
Details | |
145.74 KB,
text/plain
|
Details | |
199.02 KB,
text/plain
|
Details | |
271.92 KB,
text/plain
|
Details | |
673.53 KB,
text/plain
|
Details | |
623.17 KB,
text/plain
|
Details | |
109.63 KB,
text/plain
|
Details | |
187.56 KB,
text/plain
|
Details | |
445.51 KB,
text/plain
|
Details | |
372.25 KB,
text/plain
|
Details | |
239.00 KB,
text/plain
|
Details | |
198.69 KB,
text/plain
|
Details | |
302.08 KB,
text/plain
|
Details | |
295.57 KB,
text/plain
|
Details | |
286.59 KB,
text/plain
|
Details | |
331.08 KB,
text/plain
|
Details | |
343.21 KB,
text/plain
|
Details | |
232.02 KB,
text/plain
|
Details | |
337.49 KB,
text/plain
|
Details | |
269.75 KB,
text/plain
|
Details | |
227.49 KB,
text/plain
|
Details | |
290.43 KB,
text/plain
|
Details | |
216.24 KB,
text/plain
|
Details | |
202.91 KB,
text/plain
|
Details | |
263.84 KB,
text/plain
|
Details | |
244.26 KB,
text/plain
|
Details | |
300.69 KB,
text/plain
|
Details | |
183.95 KB,
text/plain
|
Details | |
256.48 KB,
text/plain
|
Details | |
254.54 KB,
text/plain
|
Details | |
255.46 KB,
text/plain
|
Details | |
268.95 KB,
text/plain
|
Details | |
268.71 KB,
text/plain
|
Details | |
254.23 KB,
text/plain
|
Details | |
215.82 KB,
text/plain
|
Details | |
260.59 KB,
text/plain
|
Details | |
303.54 KB,
text/plain
|
Details | |
282.22 KB,
text/plain
|
Details | |
307.29 KB,
text/plain
|
Details | |
245.98 KB,
text/plain
|
Details | |
258.29 KB,
text/plain
|
Details | |
209.74 KB,
text/plain
|
Details | |
255.44 KB,
text/plain
|
Details | |
209.12 KB,
text/plain
|
Details | |
232.11 KB,
text/plain
|
Details | |
246.86 KB,
text/plain
|
Details | |
302.73 KB,
text/plain
|
Details | |
184.32 KB,
text/plain
|
Details | |
373.34 KB,
text/plain
|
Details | |
377.56 KB,
text/plain
|
Details | |
275.12 KB,
text/plain
|
Details | |
276.36 KB,
text/plain
|
Details | |
282.32 KB,
text/plain
|
Details | |
323.73 KB,
text/plain
|
Details | |
286.96 KB,
text/plain
|
Details | |
325.39 KB,
text/plain
|
Details | |
274.51 KB,
text/plain
|
Details | |
340.96 KB,
text/plain
|
Details | |
341.21 KB,
text/plain
|
Details | |
433.82 KB,
text/plain
|
Details | |
319.63 KB,
text/plain
|
Details | |
349.31 KB,
text/plain
|
Details | |
285.41 KB,
text/plain
|
Details | |
412.60 KB,
text/plain
|
Details | |
307.48 KB,
text/plain
|
Details | |
284.58 KB,
text/plain
|
Details | |
267.15 KB,
text/plain
|
Details | |
317.80 KB,
text/plain
|
Details | |
247.40 KB,
text/plain
|
Details | |
262.19 KB,
text/plain
|
Details | |
279.78 KB,
text/plain
|
Details | |
276.19 KB,
text/plain
|
Details | |
270.99 KB,
text/plain
|
Details | |
288.98 KB,
text/plain
|
Details | |
277.55 KB,
text/plain
|
Details | |
268.15 KB,
text/plain
|
Details | |
260.38 KB,
text/plain
|
Details | |
258.75 KB,
text/plain
|
Details | |
228.23 KB,
text/plain
|
Details | |
248.97 KB,
text/plain
|
Details | |
230.88 KB,
text/plain
|
Details | |
297.71 KB,
text/plain
|
Details | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
254.26 KB,
text/plain
|
Details | |
247.42 KB,
text/plain
|
Details | |
298.59 KB,
text/plain
|
Details | |
300.09 KB,
text/plain
|
Details | |
286.41 KB,
text/plain
|
Details | |
247.84 KB,
text/plain
|
Details | |
235.36 KB,
text/plain
|
Details | |
348.40 KB,
text/plain
|
Details | |
238.59 KB,
text/plain
|
Details | |
303.47 KB,
text/plain
|
Details | |
304.32 KB,
text/plain
|
Details | |
310.83 KB,
text/plain
|
Details | |
362.37 KB,
text/plain
|
Details | |
279.26 KB,
text/plain
|
Details | |
249.87 KB,
text/plain
|
Details | |
300.43 KB,
text/plain
|
Details | |
395.53 KB,
text/plain
|
Details | |
254.79 KB,
text/plain
|
Details | |
289.73 KB,
text/plain
|
Details | |
884.05 KB,
text/plain
|
Details | |
264.39 KB,
text/plain
|
Details | |
274.68 KB,
text/plain
|
Details | |
269.90 KB,
text/plain
|
Details | |
284.04 KB,
text/plain
|
Details | |
263.35 KB,
text/plain
|
Details | |
309.45 KB,
text/plain
|
Details | |
279.44 KB,
text/plain
|
Details | |
314.55 KB,
text/plain
|
Details | |
328.00 KB,
text/plain
|
Details | |
223.62 KB,
text/plain
|
Details | |
298.52 KB,
text/plain
|
Details | |
265.16 KB,
text/plain
|
Details | |
324.87 KB,
text/plain
|
Details | |
275.77 KB,
text/plain
|
Details | |
323.18 KB,
text/plain
|
Details | |
298.36 KB,
text/plain
|
Details | |
302.86 KB,
text/plain
|
Details | |
294.30 KB,
text/plain
|
Details | |
280.29 KB,
text/plain
|
Details | |
268.99 KB,
text/plain
|
Details | |
273.30 KB,
text/plain
|
Details | |
242.67 KB,
text/plain
|
Details | |
256.37 KB,
text/plain
|
Details | |
342.72 KB,
text/plain
|
Details | |
227.26 KB,
text/plain
|
Details | |
271.83 KB,
text/plain
|
Details | |
212.70 KB,
text/plain
|
Details | |
257.28 KB,
text/plain
|
Details | |
309.30 KB,
text/plain
|
Details | |
289.45 KB,
text/plain
|
Details | |
233.23 KB,
text/plain
|
Details | |
340.76 KB,
text/plain
|
Details | |
277.63 KB,
text/plain
|
Details | |
272.79 KB,
text/plain
|
Details | |
253.63 KB,
text/plain
|
Details | |
256.35 KB,
text/plain
|
Details | |
340.04 KB,
text/plain
|
Details | |
293.59 KB,
text/plain
|
Details | |
231.88 KB,
text/plain
|
Details | |
272.07 KB,
text/plain
|
Details | |
299.02 KB,
text/plain
|
Details | |
353.89 KB,
text/plain
|
Details | |
293.04 KB,
text/plain
|
Details | |
344.22 KB,
text/plain
|
Details |
This bugs keeps track of the semi-automatic monitoring of QM_TRY failures.
Specific bugs will be filed underneath.
Reporter | ||
Comment 1•2 years ago
|
||
Reporter | ||
Comment 2•2 years ago
|
||
Reporter | ||
Comment 3•2 years ago
|
||
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Comment 4•2 years ago
|
||
Reporter | ||
Comment 5•2 years ago
|
||
:janv, I am a bit puzzled to see QM_TRY_INSPECT as a function name here?
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
5 | 5 | 5 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | dom/quota/ActorsParent.cpp#667:None <- dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED |
3 | 3 | 3 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | dom/quota/ActorsParent.cpp#667:None <- dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED |
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | dom/quota/ActorsParent.cpp#2399:WIN32(0x570) <- dom/quota/ActorsParent.cpp#4647:WIN32(0x570) <- dom/quota/ActorsParent.cpp#4230:WIN32(0x570) <- dom/quota/ActorsParent.cpp#4233:WIN32(0x570) <- dom/quota/ActorsParent.cpp#6234:WIN32(0x570) |
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | dom/quota/ActorsParent.cpp#2399:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4647:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4230:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4233:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#6234:NS_ERROR_FILE_ACCESS_DENIED |
Comment 6•2 years ago
|
||
My first guess is that rust-code-analysis-cli
is confused by the macro in some places. I would need to see the metrics file to tell more. Should I try myself ?
Comment 7•2 years ago
|
||
Or maybe the script needs a list of functions that should be ignored (if QM_TRY is considered as a function) and use other function name which is not the closest one.
Reporter | ||
Comment 8•2 years ago
•
|
||
(In reply to Jan Varga [:janv] from comment #6)
My first guess is that
rust-code-analysis-cli
is confused by the macro in some places. I would need to see the metrics file to tell more. Should I try myself ?
This seems to be the case. Fetching ActorsParent.cpp manually and applying rust-code-analysis-cli -m -O json -o /tmp -p /tmp/ActorsParent.cpp
manually yields:
...
{
"name": "LoadLocalStorageArchiveVersion",
"start_line": 658,
"end_line": 755,
"kind": "function",
"spaces": [
{
"name": "QM_TRY_INSPECT",
"start_line": 662,
"end_line": 745,
"kind": "function",
"spaces": [],
"metrics": {
"nargs": {
"sum": 7.0,
"average": 7.0
},
"nexits": {
"sum": 0.0,
"average": 0.0
},
"cognitive": {
"sum": 0.0,
"average": 0.0
},
"cyclomatic": {
"sum": 7.0,
"average": 7.0
},
"halstead": {
"n1": 19.0,
"N1": 157.0,
"n2": 65.0,
"N2": 119.0,
"length": 276.0,
"estimated_program_length": 472.16453060227764,
"purity_ratio": 1.710741052906803,
"vocabulary": 84.0,
"volume": 1764.279608686938,
"difficulty": 17.392307692307693,
"level": 0.05749668288367979,
"effort": 30684.893809547437,
"time": 1704.7163227526353,
"bugs": 0.32670954919749584
},
"loc": {
"sloc": 84.0,
"ploc": 60.0,
"lloc": 1.0,
"cloc": 5.0,
"blank": 19.0
},
"nom": {
"functions": 1.0,
"closures": 0.0,
"total": 1.0
},
"mi": {
"mi_original": 58.738179650614256,
"mi_sei": 28.20463653446185,
"mi_visual_studio": 34.34981266117793
}
}
},
{
"name": "~Observer",
"start_line": 747,
"end_line": 747,
"kind": "function",
"spaces": [],
"metrics": {
"nargs": {
"sum": 0.0,
"average": 0.0
},
"nexits": {
"sum": 0.0,
"average": 0.0
},
"cognitive": {
"sum": 0.0,
"average": 0.0
},
"cyclomatic": {
"sum": 1.0,
"average": 1.0
},
"halstead": {
"n1": 4.0,
"N1": 6.0,
"n2": 3.0,
"N2": 3.0,
"length": 9.0,
"estimated_program_length": 12.754887502163468,
"purity_ratio": 1.4172097224626077,
"vocabulary": 7.0,
"volume": 25.26619429851844,
"difficulty": 2.0,
"level": 0.5,
"effort": 50.53238859703688,
"time": 2.807354922057604,
"bugs": 0.004556086527391188
},
"loc": {
"sloc": 1.0,
"ploc": 1.0,
"lloc": 1.0,
"cloc": 0.0,
"blank": 0.0
},
"nom": {
"functions": 1.0,
"closures": 0.0,
"total": 1.0
},
"mi": {
"mi_original": 153.97676999581998,
"mi_sei": 146.54249035246173,
"mi_visual_studio": 90.04489473439764
}
}
}
],
"metrics": {
"nargs": {
"sum": 8.0,
"average": 2.6666666666666665
},
"nexits": {
"sum": 0.0,
"average": 0.0
},
"cognitive": {
"sum": 0.0,
"average": 0.0
},
"cyclomatic": {
"sum": 9.0,
"average": 3.0
},
"halstead": {
"n1": 20.0,
"N1": 176.0,
"n2": 68.0,
"N2": 132.0,
"length": 308.0,
"estimated_program_length": 500.38603510277034,
"purity_ratio": 1.6246299840999037,
"vocabulary": 88.0,
"volume": 1989.5049385402876,
"difficulty": 19.41176470588235,
"level": 0.05151515151515152,
"effort": 38619.80174813499,
"time": 2145.5445415630547,
"bugs": 0.3808483736064195
},
"loc": {
"sloc": 98.0,
"ploc": 69.0,
"lloc": 3.0,
"cloc": 5.0,
"blank": 24.0
},
"nom": {
"functions": 3.0,
"closures": 0.0,
"total": 3.0
},
"mi": {
"mi_original": 55.15619306227286,
"mi_sei": 21.9305595486369,
"mi_visual_studio": 32.25508366214787
}
}
},
...
The line numbers are clearly wrong here. And similar problems are happening also in other places around QM_TRY_INSPECT. As the line numbers also of LoadLocalStorageArchiveVersion
itself are wrong (end line), I fear that ignoring QM_* function names might not always help.
:marco, is this something you ever noticed in rust-code-analysis-cli
?
Comment 9•2 years ago
|
||
Is there a way to get rust-code-analysis to dump the tree-sitter AST/parse? I presume there's an error node in the given method that causes it to miss the end of the function and eat further.
Comment 10•2 years ago
|
||
:asuth, yes it's possible:
cargo run -p rust-code-analysis-cli -- -p /tmp/ActorsParent.cpp -d --ls 658 --le 671
ls
and le
are here to limit the ast dump to nodes which are between these two line numbers (included).
and the problem is because of
QM_TRY_INSPECT(const auto& stmt, ...
because it isn't really grammatically correct.
In rca we've a grammar for mozilla-central code:
https://github.com/mozilla/rust-code-analysis/blob/master/tree-sitter-mozcpp/grammar.js
so we can amend it to handle special cases (it's the goal of this grammar), feel free to file a bug.
Comment 11•2 years ago
|
||
I wrote a patch for rca to fix the problem:
https://github.com/mozilla/rust-code-analysis/pull/611
Reporter | ||
Comment 12•2 years ago
|
||
(In reply to Calixte Denizet (:calixte) from comment #11)
I wrote a patch for rca to fix the problem:
https://github.com/mozilla/rust-code-analysis/pull/611
Thanks a lot!
Reporter | ||
Comment 13•2 years ago
|
||
It works:
< 5 | 5 | 5 | dom/quota/ActorsParent.cpp:QM_TRY_INSPECT | [dom/quota/ActorsParent.cpp#667:None](https://hg.mozilla.org/releases/mozilla-beta/annotate/276ecc030f1c341ecf57287999ff4bec10adfb4f/dom/quota/ActorsParent.cpp#l667) <- [dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED](https://hg.mozilla.org/releases/mozilla-beta/annotate/276ecc030f1c341ecf57287999ff4bec10adfb4f/dom/quota/ActorsParent.cpp#l5875)
---
> 5 | 5 | 5 | dom/quota/ActorsParent.cpp:LoadLocalStorageArchiveVersion | [dom/quota/ActorsParent.cpp#667:None](https://hg.mozilla.org/releases/mozilla-beta/annotate/276ecc030f1c341ecf57287999ff4bec10adfb4f/dom/quota/ActorsParent.cpp#l667) <- [dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED](https://hg.mozilla.org/releases/mozilla-beta/annotate/276ecc030f1c341ecf57287999ff4bec10adfb4f/dom/quota/ActorsParent.cpp#l5875)
Thanks!
Reporter | ||
Comment 14•2 years ago
|
||
Reporter | ||
Comment 15•2 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
2 | 2 | 2 | dom/quota/ActorsParent.cpp:LoadLocalStorageArchiveVersion | dom/quota/ActorsParent.cpp#667:None <- dom/quota/ActorsParent.cpp#5875:NS_ERROR_FILE_CORRUPTED |
Reporter | ||
Comment 16•2 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
2 | 2 | 2 | dom/quota/ActorsParent.cpp:QuotaManager::EnsureStorageIsInitialized | dom/quota/ActorsParent.cpp#6011:NS_ERROR_FILE_ACCESS_DENIED |
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QuotaManager::EnsureStorageIsInitialized | dom/quota/ActorsParent.cpp#6011:NS_ERROR_STORAGE_BUSY |
Reporter | ||
Comment 17•2 years ago
|
||
Needs new bug:
Reporter | ||
Comment 18•2 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/quota/ActorsParent.cpp:MaybeUpdateGroupForOrigin | dom/quota/ActorsParent.cpp#1829:NS_ERROR_MALFORMED_URI <- dom/quota/ActorsParent.cpp#4596:NS_ERROR_MALFORMED_URI <- dom/quota/ActorsParent.cpp#4628:NS_ERROR_MALFORMED_URI |
Reporter | ||
Comment 19•2 years ago
|
||
Needs new bug:
Reporter | ||
Comment 20•2 years ago
|
||
Needs new bug:
Reporter | ||
Comment 21•2 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 2 | 2 | dom/quota/ActorsParent.cpp:QuotaManager::CopyLocalStorageArchiveFromWebAppsStore | dom/quota/ActorsParent.cpp#5514:WIN32(0x570) <- dom/quota/ActorsParent.cpp#5859:WIN32(0x570) <- dom/quota/ActorsParent.cpp#5863:WIN32(0x570) <- dom/quota/ActorsParent.cpp#6041:WIN32(0x570) |
Reporter | ||
Comment 22•2 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/quota/QuotaCommon.cpp:ExecuteSingleStep | dom/quota/QuotaCommon.cpp#201:NS_ERROR_OUT_OF_MEMORY <- dom/quota/ActorsParent.cpp#665:NS_ERROR_OUT_OF_MEMORY <- dom/quota/ActorsParent.cpp#5875:NS_ERROR_OUT_OF_MEMORY <- dom/quota/ActorsParent.cpp#6041:NS_ERROR_OUT_OF_MEMORY |
Reporter | ||
Comment 23•2 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpdateUsageFile | dom/localstorage/ActorsParent.cpp#1000:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8123:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8129:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8137:NS_ERROR_FILE_IS_LOCKED <- dom/quota/ActorsParent.cpp#4867:NS_ERROR_FILE_IS_LOCKED <- dom/quota/ActorsParent.cpp#4939:NS_ERROR_FILE_IS_LOCKED |
1 | 1 | 2 | dom/localstorage/ActorsParent.cpp:UpdateUsageFile | dom/localstorage/ActorsParent.cpp#1000:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8123:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8129:NS_ERROR_FILE_IS_LOCKED <- dom/localstorage/ActorsParent.cpp#8137:NS_ERROR_FILE_IS_LOCKED <- dom/quota/ActorsParent.cpp#4867:NS_ERROR_FILE_IS_LOCKED <- dom/quota/ActorsParent.cpp#4939:NS_ERROR_FILE_IS_LOCKED |
Reporter | ||
Comment 24•2 years ago
|
||
Needs new bug:
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QuotaManager::MaybeCreateOrUpgradeStorage | dom/quota/ActorsParent.cpp#5811:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#6013:NS_ERROR_FILE_NO_DEVICE_SPACE |
1 | 1 | 1 | dom/quota/ActorsParent.cpp:QuotaManager::MaybeCreateOrUpgradeStorage | dom/quota/ActorsParent.cpp#5811:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#6013:NS_ERROR_FILE_NO_DEVICE_SPACE |
Reporter | ||
Comment 25•2 years ago
|
||
Reporter | ||
Comment 26•2 years ago
|
||
Reporter | ||
Comment 27•2 years ago
|
||
Reporter | ||
Comment 28•2 years ago
|
||
Reporter | ||
Comment 29•2 years ago
|
||
The last two files are almost a week old, I will not file the single errors.
Reporter | ||
Comment 30•2 years ago
|
||
Reporter | ||
Comment 31•2 years ago
|
||
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Comment 32•2 years ago
|
||
Hopefully better split with less false errors.
Reporter | ||
Comment 33•2 years ago
|
||
Also here, hopefully better split with less false alarms.
Reporter | ||
Comment 34•2 years ago
|
||
Reporter | ||
Comment 35•2 years ago
|
||
Reporter | ||
Comment 36•2 years ago
|
||
Reporter | ||
Comment 37•2 years ago
|
||
Reporter | ||
Comment 38•2 years ago
|
||
Reporter | ||
Comment 39•2 years ago
|
||
Reporter | ||
Comment 40•2 years ago
|
||
Reporter | ||
Comment 41•2 years ago
|
||
Reporter | ||
Comment 42•2 years ago
|
||
Reporter | ||
Comment 43•2 years ago
|
||
Reporter | ||
Comment 44•2 years ago
|
||
Reporter | ||
Comment 45•2 years ago
•
|
||
Looking at the frequency of different stacks with nsResult:
Errors:
> cat qmerrors_until_1622505580053.json | grep result | sort | uniq -c
166 "result": "NS_ERROR_FILE_ACCESS_DENIED",
25 "result": "NS_ERROR_FILE_DIR_NOT_EMPTY",
18 "result": "NS_ERROR_FILE_FS_CORRUPTED",
10 "result": "NS_ERROR_FILE_IS_LOCKED",
3 "result": "NS_ERROR_FILE_NO_DEVICE_SPACE",
50 "result": "NS_ERROR_FILE_NOT_FOUND",
3 "result": "NS_ERROR_FILE_READ_ONLY",
4 "result": null,
Warnings:
> cat qmwarnings_until_1622505580053.json | grep result | sort | uniq -c
65 "result": "NS_ERROR_FAILURE",
27 "result": "NS_ERROR_FILE_ACCESS_DENIED",
15 "result": "NS_ERROR_FILE_CORRUPTED",
3 "result": "NS_ERROR_FILE_DEVICE_FAILURE",
1 "result": "NS_ERROR_FILE_DIR_NOT_EMPTY",
9 "result": "NS_ERROR_FILE_IS_LOCKED",
1 "result": "NS_ERROR_FILE_NO_DEVICE_SPACE",
108 "result": "NS_ERROR_FILE_NOT_FOUND",
2 "result": "NS_ERROR_FILE_READ_ONLY",
45 "result": "NS_ERROR_FILE_TARGET_DOES_NOT_EXIST",
6 "result": "NS_ERROR_FILE_TOO_BIG",
44 "result": "NS_ERROR_ILLEGAL_VALUE",
6 "result": "NS_ERROR_MALFORMED_URI",
7 "result": "NS_ERROR_STORAGE_IOERR",
6 "result": "NS_ERROR_UNEXPECTED",
55 "result": null,
Please note, that this does not count, how often those stacks occur, it is just the number of unique stack frames in this script run (we could do better but not with a 5min bash line).
Things worth an investigation:
Error | Comment |
---|---|
NS_ERROR_FILE_DEVICE_FAILURE | Should never be a Warning? |
NS_ERROR_FILE_NO_DEVICE_SPACE | Should never be a Warning? |
NS_ERROR_FAILURE | See bug 1712582 |
NS_ERROR_UNEXPECTED | Unspecific? |
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Comment 46•2 years ago
|
||
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Comment 47•2 years ago
|
||
Reporter | ||
Comment 48•2 years ago
|
||
Reporter | ||
Comment 49•2 years ago
|
||
Reporter | ||
Comment 50•2 years ago
|
||
Reporter | ||
Comment 51•2 years ago
|
||
Reporter | ||
Comment 52•2 years ago
|
||
Reporter | ||
Comment 53•2 years ago
|
||
Reporter | ||
Comment 54•2 years ago
|
||
Reporter | ||
Comment 55•2 years ago
|
||
Reporter | ||
Comment 56•2 years ago
|
||
Reporter | ||
Comment 57•2 years ago
|
||
Reporter | ||
Comment 58•2 years ago
|
||
Reporter | ||
Comment 59•2 years ago
|
||
New entries (bugs to file):
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:PrepareDatastoreOp::VerifyDatabaseInformation | dom/localstorage/ActorsParent.cpp#7129:None <- dom/localstorage/ActorsParent.cpp#6940:NS_ERROR_FILE_CORRUPTED |
Clients | Sessions | Hits | Anchor | Stack |
---|---|---|---|---|
1 | 1 | 1 | dom/quota/ActorsParent.cpp:GetLastModifiedTime | dom/quota/ActorsParent.cpp#2356:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#2337:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#2340:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#2337:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#2340:NS_ERROR_FILE_FS_CORRUPTED |
Reporter | ||
Comment 60•2 years ago
|
||
Reporter | ||
Comment 61•2 years ago
|
||
Assignee | ||
Comment 62•2 years ago
|
||
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 63•2 years ago
|
||
Assignee | ||
Comment 64•2 years ago
|
||
Assignee | ||
Comment 65•2 years ago
|
||
Assignee | ||
Comment 66•2 years ago
|
||
Assignee | ||
Comment 67•2 years ago
|
||
Assignee | ||
Comment 68•2 years ago
|
||
Assignee | ||
Comment 69•2 years ago
|
||
Assignee | ||
Comment 70•2 years ago
|
||
Assignee | ||
Comment 71•2 years ago
|
||
Assignee | ||
Comment 72•2 years ago
|
||
Assignee | ||
Comment 73•2 years ago
|
||
Assignee | ||
Comment 74•2 years ago
|
||
Assignee | ||
Comment 75•2 years ago
|
||
Assignee | ||
Comment 76•2 years ago
|
||
Assignee | ||
Comment 77•2 years ago
|
||
Assignee | ||
Comment 78•2 years ago
|
||
Assignee | ||
Comment 79•2 years ago
|
||
Assignee | ||
Comment 80•1 year ago
|
||
Assignee | ||
Comment 81•1 year ago
|
||
Assignee | ||
Comment 82•1 year ago
|
||
Assignee | ||
Comment 83•1 year ago
|
||
Assignee | ||
Comment 84•1 year ago
|
||
Assignee | ||
Comment 85•1 year ago
|
||
Assignee | ||
Comment 86•1 year ago
|
||
Assignee | ||
Comment 87•1 year ago
|
||
Assignee | ||
Comment 88•1 year ago
|
||
Assignee | ||
Comment 89•1 year ago
|
||
Assignee | ||
Comment 90•1 year ago
|
||
Assignee | ||
Comment 91•1 year ago
|
||
Assignee | ||
Comment 92•1 year ago
|
||
Assignee | ||
Comment 93•1 year ago
|
||
Assignee | ||
Comment 94•1 year ago
|
||
Assignee | ||
Comment 95•1 year ago
|
||
Assignee | ||
Comment 96•1 year ago
|
||
Assignee | ||
Comment 97•1 year ago
|
||
Assignee | ||
Comment 98•1 year ago
|
||
Assignee | ||
Comment 99•1 year ago
|
||
Assignee | ||
Comment 100•1 year ago
|
||
Assignee | ||
Comment 101•1 year ago
|
||
Assignee | ||
Comment 102•1 year ago
|
||
Assignee | ||
Comment 103•1 year ago
|
||
Assignee | ||
Comment 104•1 year ago
|
||
Assignee | ||
Comment 105•1 year ago
|
||
Assignee | ||
Comment 106•1 year ago
|
||
Assignee | ||
Comment 107•1 year ago
|
||
Assignee | ||
Comment 108•1 year ago
|
||
Assignee | ||
Comment 109•1 year ago
|
||
Assignee | ||
Comment 110•1 year ago
|
||
Assignee | ||
Comment 111•1 year ago
|
||
Assignee | ||
Comment 112•1 year ago
|
||
Assignee | ||
Comment 113•1 year ago
|
||
Assignee | ||
Comment 114•1 year ago
|
||
Assignee | ||
Comment 115•1 year ago
|
||
Assignee | ||
Comment 116•1 year ago
|
||
Assignee | ||
Comment 117•1 year ago
|
||
Assignee | ||
Comment 118•1 year ago
|
||
Assignee | ||
Comment 119•1 year ago
|
||
The rust-code-analysis-cli
had to be run again because previously mostly unknown anchors were returned.
Assignee | ||
Comment 120•1 year ago
|
||
Assignee | ||
Comment 121•1 year ago
|
||
Assignee | ||
Comment 122•1 year ago
|
||
Assignee | ||
Comment 123•11 months ago
|
||
Assignee | ||
Comment 124•11 months ago
|
||
Assignee | ||
Comment 125•11 months ago
|
||
Assignee | ||
Comment 126•11 months ago
|
||
Assignee | ||
Comment 127•11 months ago
|
||
Assignee | ||
Comment 128•10 months ago
|
||
Assignee | ||
Comment 129•10 months ago
|
||
Assignee | ||
Comment 130•10 months ago
|
||
Comment 131•10 months ago
|
||
Pushed by jkrause@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13c0b769cc03 Add `context` to Bugzilla comment markup. r=jstutte,dom-storage-reviewers
Comment 132•10 months ago
|
||
bugherder |
Reporter | ||
Comment 133•10 months ago
|
||
The closure was not intended here, this is a perennial thing.
Assignee | ||
Comment 134•10 months ago
|
||
Updated•10 months ago
|
Assignee | ||
Comment 135•10 months ago
|
||
Assignee | ||
Comment 136•10 months ago
|
||
Assignee | ||
Comment 137•10 months ago
|
||
Assignee | ||
Comment 138•9 months ago
|
||
Assignee | ||
Comment 139•9 months ago
|
||
Assignee | ||
Comment 140•9 months ago
|
||
Assignee | ||
Comment 141•9 months ago
|
||
Assignee | ||
Comment 142•9 months ago
|
||
Assignee | ||
Comment 143•9 months ago
|
||
Assignee | ||
Comment 144•9 months ago
|
||
Assignee | ||
Comment 145•9 months ago
|
||
Assignee | ||
Comment 146•9 months ago
|
||
Assignee | ||
Comment 147•8 months ago
|
||
Assignee | ||
Comment 148•8 months ago
|
||
Assignee | ||
Comment 149•8 months ago
|
||
Assignee | ||
Comment 150•8 months ago
|
||
Assignee | ||
Comment 151•8 months ago
|
||
Assignee | ||
Comment 152•8 months ago
|
||
Assignee | ||
Comment 153•8 months ago
|
||
Assignee | ||
Comment 154•8 months ago
|
||
Assignee | ||
Comment 155•7 months ago
|
||
Assignee | ||
Comment 156•6 months ago
|
||
Assignee | ||
Comment 157•6 months ago
|
||
Assignee | ||
Comment 158•6 months ago
|
||
Assignee | ||
Comment 159•6 months ago
|
||
Assignee | ||
Comment 160•6 months ago
|
||
Assignee | ||
Comment 161•6 months ago
|
||
Assignee | ||
Comment 162•5 months ago
|
||
Assignee | ||
Comment 163•5 months ago
|
||
Assignee | ||
Comment 164•5 months ago
|
||
Assignee | ||
Comment 165•5 months ago
|
||
Assignee | ||
Comment 166•5 months ago
|
||
Assignee | ||
Comment 167•4 months ago
|
||
Assignee | ||
Comment 168•4 months ago
|
||
Assignee | ||
Comment 169•4 months ago
|
||
Assignee | ||
Comment 170•4 months ago
|
||
Assignee | ||
Comment 171•4 months ago
|
||
Assignee | ||
Comment 172•4 months ago
|
||
Assignee | ||
Comment 173•3 months ago
|
||
Assignee | ||
Comment 174•3 months ago
|
||
Assignee | ||
Comment 175•3 months ago
|
||
Assignee | ||
Comment 176•3 months ago
|
||
Assignee | ||
Comment 177•3 months ago
|
||
Assignee | ||
Comment 178•2 months ago
|
||
Assignee | ||
Comment 179•2 months ago
|
||
Assignee | ||
Comment 180•2 months ago
|
||
Assignee | ||
Comment 181•2 months ago
|
||
Assignee | ||
Comment 182•2 months ago
|
||
Assignee | ||
Comment 183•2 months ago
|
||
Assignee | ||
Comment 184•2 months ago
|
||
Assignee | ||
Comment 185•2 months ago
|
||
Assignee | ||
Comment 186•2 months ago
|
||
Assignee | ||
Comment 187•1 month ago
|
||
Assignee | ||
Comment 188•1 month ago
|
||
Assignee | ||
Comment 189•1 month ago
|
||
Assignee | ||
Comment 190•1 month ago
|
||
Assignee | ||
Comment 191•29 days ago
|
||
Assignee | ||
Comment 192•25 days ago
|
||
Assignee | ||
Comment 193•22 days ago
|
||
Assignee | ||
Comment 194•17 days ago
|
||
Assignee | ||
Comment 195•15 days ago
|
||
Assignee | ||
Comment 196•11 days ago
|
||
Description
•