Closed Bug 1702415 Opened 3 years ago Closed 3 years ago

Fix relative path calculation of exported source files (like QuotaCommon.h)

Categories

(Core :: Storage: Quota Manager, defect, P2)

defect

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(3 files)

MakeRelativeSourceFileName currently returns only file name for QuotaCommon.h, the problem is that the file is exported during a build phase and is then used from the exported destination, so the full path produced by __FILE__ has different prefix (source tree base).

See Also: → 1703801

This patch adjusts other similar names as well:
MakeRelativeSourceFileName -> MakeRelativeSourceFilePath
relativeSourceFile -> relativeSourceFilePath
thisFileRelativeSourceFileName -> thisFileRelativeSourceFilePath

Summary: Fix relative source file name calculation for exported files (like QuotaCommon.h) → Fix source file relative path calculation for exported files (like QuotaCommon.h)
Summary: Fix source file relative path calculation for exported files (like QuotaCommon.h) → Fix relative path calculation of exported source files (like QuotaCommon.h)
Attachment #9217482 - Attachment description: Bug 1702415 - Fix relative source file name calculation for exported files (like QuotaCommon.h); r=#dom-storage → Bug 1702415 - Fix relative path calculation of exported source files (like QuotaCommon.h); r=#dom-storage
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d54750b9f34
Replace aSourceFile with aSourceFilePath; r=dom-storage-reviewers,jstutte,asuth
https://hg.mozilla.org/integration/autoland/rev/e00a02611cd4
Replace aSourceLine with aSourceFileLine; r=dom-storage-reviewers,jstutte,asuth
https://hg.mozilla.org/integration/autoland/rev/d10768c1b3ae
Fix relative path calculation of exported source files (like QuotaCommon.h); r=dom-storage-reviewers,asuth

Backed out 3 changesets (bug 1702415) for causing quota related build bustages. CLOSED TREE

Push with failures

Failure log

Backout link

Flags: needinfo?(jvarga)
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c9d006772db
Replace aSourceFile with aSourceFilePath; r=dom-storage-reviewers,jstutte,asuth
https://hg.mozilla.org/integration/autoland/rev/8adfd0fb0253
Replace aSourceLine with aSourceFileLine; r=dom-storage-reviewers,jstutte,asuth
Flags: needinfo?(jvarga)
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8df2a95e6e68
Fix relative path calculation of exported source files (like QuotaCommon.h); r=dom-storage-reviewers,asuth
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: