1702433 - New/Copy popup behind New button in Message Filter Manager is missing padding

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Klaus B.]

Attachment: filter padding.png

See screenshot, was looking better in TB 68. Not looking good in TB 78 and TB 88.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1702433-popup-height.patch

This is Windows only but it is a similar style as https://searchfox.org/comm-central/rev/a94834c95f86b1882a46b826154f7bef4d8db2a9/mail/themes/linux/mail/themeableDialog.css#63-68 for Linux only to make the menuitem a bit taller and to be as tall as the native menuitem.

Comment 2

[Richard Marti (:Paenglab)]

Ah forgot: needs bug 1703268 applied first.

When it gets a r+ I'll provide patches for beta and 78.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9213800 [details] [diff] [review]
1702433-popup-height.patch

Review of attachment 9213800 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7a2568f1bd31
[Windows] Make the temeable popups taller. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1702433-popup-height-beta-ESR.patch

[Approval Request Comment]
User impact if declined: too small popup in themeable dialogs
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a87c38920143
Follow-up: use the correct media query. r=me DONTBUILD

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9214076 [details] [diff] [review]
1702433-popup-height-beta-ESR.patch

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 88.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/7d32bdb0b9ec
https://hg.mozilla.org/releases/comm-beta/rev/f12287e92165

Comment 9

[Rob Lemley [:rjl]]

Beta Backout (combined from comment 8)
https://hg.mozilla.org/releases/comm-beta/rev/e4ba80c66ee1

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 88.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/f694fde1b11e

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9214076 [details] [diff] [review]
1702433-popup-height-beta-ESR.patch

[Triage Comment]
Approved for esr78

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.10.0:
https://hg.mozilla.org/releases/comm-esr78/rev/a77ebde6ad21