Closed Bug 1702459 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28333 - CSSNumericValue.add and sub must throw TypeException when type different

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28333 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28333
Details from upstream follow.

b'Seokho Song <0xdevssh@gmail.com>' wrote:

CSSNumericValue.add and sub must throw TypeException when type different

According to the spec [1], CSSNumericValue.add must throw the exception
on types are different. CSSNumericValue.sub uses CSSMathSum
with negating, So it is samely required throw the exception.

Therefore, add ThrowTypeErrorIfValueIsNull() helper function
which receive the value and exception_state for throw TypeException
after checking the value is nullptr.

[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-add

Bug: 1193923
Change-Id: Ic131e641d2e3251d119eca04a0ce55f194596710

Reviewed-on: https://chromium-review.googlesource.com/2798149
WPT-Export-Revision: 259bf2308fed978517701c1eb9e4e8a25ec3a9ea

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 63 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
PASS : 61
FAIL : 2

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-typed-om/stylevalue-subclasses/numeric-objects/arithmetic.tentative.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)

Tests Disabled in Gecko Infrastructure

/css/css-typed-om/stylevalue-subclasses/numeric-objects/arithmetic.tentative.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90a9e77a1eb0
[wpt PR 28333] - CSSNumericValue.add and sub must throw TypeException when type different, a=testonly

https://hg.mozilla.org/mozilla-central/rev/90a9e77a1eb0

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.