1702525 - Urlbar divider is thicker when search mode is opened

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P5)

Description

[Petruta Horea [:phorea], Desktop QA]

Attachment: comparison between search mode on and off

Note

• Reproducible with and without Proton preferences

Affected versions

• Fx89.0a1 20210401094845

Affected platforms

• Windows 10 64-bit
• OSX 10.14

Steps to reproduce

1. Launch Firefox and open the urlbar panel
2. Observe the divider between the bar and the search shortcuts
3. Select a search shortcut
4. Observe the divider between the bar and the search shortcuts

Expected result

• Divider has the same height (1px) regardless open search mode (matches Figma)

Actual result

• Divider height is 2px when search mode is opened for any search engine
• Local search shortcuts don't reproduce this issue

Regression range

• This was introduced with Nightly 89.0a1 2021-03-26, will look for a more specific range ASAP

Comment 1

[Marco Bonardo [:mak]]

sounds like the 2 dividers around results, in search mode there's no results, we should hide one of the 2 dividers.

Comment 2

[Pablo]

mozregression

build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/W26E0BLGSzKSpM25qN0zXg/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: 976e50ff768ee723f173e41b9ca211c7278d09af
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=976e50ff768ee723f173e41b9ca211c7278d09af&tochange=cad5e739410ba4a3d90f8fd6f921616b77f08f68

Bug 1695276 - Partially restyle the search bar panel to make it more consistent with the Address Bar in Proton

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1702525 - Urlbar divider is thicker when search mode is open without suggestions. r=harry

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33f51bca9422
Urlbar divider is thicker when search mode is open without suggestions. r=harry,desktop-theme-reviewers

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/33f51bca9422

Comment 6

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 89 beta 5 across platforms.