Closed Bug 1702525 Opened 8 months ago Closed 8 months ago

Urlbar divider is thicker when search mode is opened

Categories

(Firefox :: Address Bar, defect, P5)

Firefox 89
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: phorea, Assigned: mak)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-address-bar])

Attachments

(2 files)

Note

  • Reproducible with and without Proton preferences

Affected versions

  • Fx89.0a1 20210401094845

Affected platforms

  • Windows 10 64-bit
  • OSX 10.14

Steps to reproduce

  1. Launch Firefox and open the urlbar panel
  2. Observe the divider between the bar and the search shortcuts
  3. Select a search shortcut
  4. Observe the divider between the bar and the search shortcuts

Expected result

  • Divider has the same height (1px) regardless open search mode (matches Figma)

Actual result

  • Divider height is 2px when search mode is opened for any search engine
  • Local search shortcuts don't reproduce this issue

Regression range

  • This was introduced with Nightly 89.0a1 2021-03-26, will look for a more specific range ASAP

sounds like the 2 dividers around results, in search mode there's no results, we should hide one of the 2 dividers.

Priority: -- → P5
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regression
Regressed by: 1695276
Assignee: nobody → mak
Status: NEW → ASSIGNED
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/33f51bca9422
Urlbar divider is thicker when search mode is open without suggestions. r=harry,desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified as fixed using Firefox 89 beta 5 across platforms.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.