1702532 - Ensure browser/extensions/screenshots/assertIsBlankDocument.js passes eslint check

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement, P3)

Description

[Emma Malysz]

We should fix these errors in order to enable eslint in the screenshots directory.

To find the errors:

1. Temporarily comment out https://searchfox.org/mozilla-central/rev/4fa18c26fa907f38d56b599571b9846af1506f3c/.eslintignore#43-45
2. Run ./mach lint browser/extensions/screenshots/assertIsBlankDocument.js

First, check if this can receive an automatic fix via:
./mach lint browser/extensions/screenshots/assertIsBlankDocument.js --fix.

Otherwise, investigate the failures and see if it requires a manual fix

Comment 1

[Falguni Islam]

Attachment: Bug 1702532: fix eslint check passes in browser/extensions/screenshots/assertIsBlankDocument.js.

Comment 2

[Kajal Sah]

In this file browser/extensions/screenshots/assertIsBlankDocument.js, the eslint failues that need to be manually corrected is:

'browser' is undefined in line 10.

I could not understand where do I need to import the browser. Or is there any other way to first define the browser variable?

Comment 3

[Emma Malysz]

To fix that error, we can include a comment that indicates browser is a global var. Here's an example:
https://searchfox.org/mozilla-central/rev/54f37fc1ac0f98b590af51e01ce82bb74179bf63/browser/extensions/screenshots/background/analytics.js#1-5

For just browser we would want,
/* globals browser */

Comment 4

[Kajal Sah]

Attachment: Bug 1702532 - Fixes eslint failures in browser/extensions/screenshots/assertIsBlankDocument.js. r?emalysz

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78344c8e1ec2
fix eslint check passes in browser/extensions/screenshots/assertIsBlankDocument.js. r=emalysz

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/78344c8e1ec2