Closed Bug 1702573 Opened 4 years ago Closed 4 years ago

Ensure browser/extensions/screenshots/selector/ui.js passes eslint check

Categories

(Firefox :: Screenshots, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: emmamalysz, Assigned: kajalsah107)

References

Details

(Whiteboard: [outreachy-2021-screenshots])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1702532 +++

We should fix these errors in order to enable eslint in the screenshots directory.

To find the errors:

  1. Temporarily comment out https://searchfox.org/mozilla-central/rev/4fa18c26fa907f38d56b599571b9846af1506f3c/.eslintignore#43-45
  2. Run ./mach lint browser/extensions/screenshots/selector/ui.js

First, check if this can receive an automatic fix via:
./mach lint browser/extensions/screenshots/selector/ui.js --fix.

Otherwise, investigate the failures and see if it requires a manual fix

Whiteboard: [outreachy-2021-screenshots]
Assignee: nobody → kajalsah107
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6dd0e7f9c6c3 Fixes eslint failures in browser/extensions/screenshots/selector/ui.js. r=emalysz
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: