1702579 - Ensure browser/extensions/screenshots/test/browser/injection-page.html passes eslint check

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement, P3)

Description

[Emma Malysz]

+++ This bug was initially created as a clone of Bug #1702532 +++

We should fix these errors in order to enable eslint in the screenshots directory.

To find the errors:

1. Temporarily comment out https://searchfox.org/mozilla-central/rev/4fa18c26fa907f38d56b599571b9846af1506f3c/.eslintignore#43-45
2. Run ./mach lint browser/extensions/screenshots/test/browser/injection-page.html

First, check if this can receive an automatic fix via:
./mach lint browser/extensions/screenshots/test/browser/injection-page.html --fix.

Otherwise, investigate the failures and see if it requires a manual fix

Comment 1

[Kajal Sah]

Hi, here also the only eslint failure comes with the message observer is not defined. Since this is an HTML file, how do we solve this lint error? Using /* globals observer */ does not seem to work.

Comment 2

[Falguni Islam]

Attachment: Bug 1702579: fix eslint browser/extensions/screenshots/test/browser/injection-page.html

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/499b142f69c4
fix eslint browser/extensions/screenshots/test/browser/injection-page.html r=emalysz

Comment 4

[Atila Butkovits]

Backed out for causing lint failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c2b51a4cb308ed826f7ec5ef2230a0ca55243ce1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=ByjdronKSjOHVWN-e2L70Q.0&revision=499b142f69c41b2a474aad55a787c84cc43c3164&searchStr=linting%2Copt%2Cjavascript%2Cchecks%2Csource-test-mozlint-eslint%2Ces

Failure log: https://treeherder.mozilla.org/logviewer?job_id=335780250&repo=autoland&lineNumber=371
https://treeherder.mozilla.org/logviewer?job_id=335781982&repo=autoland&lineNumber=3746

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aa65b35d774
fix eslint pass browser/extensions/screenshots/test/browser/injection-page.html r=emalysz

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_screenshots_injection.js

backout: https://hg.mozilla.org/integration/autoland/rev/2e30fadcb4d52f15b3c3bc34367cd1b3329d75fe

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=ayb3J1J_QtKurs7poSW-bA.0&revision=4aa65b35d77442002175fd45c65e440aa898268d

failure log: https://treeherder.mozilla.org/logviewer?job_id=335859079&repo=autoland&lineNumber=2242

[task 2021-04-08T16:42:46.999Z] 16:42:46 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "https://example.com/browser/browser/extensions/screenshots/test/browser/injection-page.html" line: 0}]
[task 2021-04-08T16:42:46.999Z] 16:42:46 INFO - Buffered messages finished
[task 2021-04-08T16:42:47.000Z] 16:42:46 INFO - TEST-UNEXPECTED-FAIL | browser/extensions/screenshots/test/browser/browser_screenshots_injection.js | Test timed out -
[task 2021-04-08T16:42:47.015Z] 16:42:47 INFO - GECKO(1567) | MEMORY STAT | vsize 130550912MB | residentFast 1984MB
[task 2021-04-08T16:42:47.015Z] 16:42:47 INFO - TEST-OK | browser/extensions/screenshots/test/browser/browser_screenshots_injection.js | took 120301ms
[task 2021-04-08T16:42:47.015Z] 16:42:47 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-08T16:42:47.016Z] 16:42:47 INFO - TEST-UNEXPECTED-FAIL | browser/extensions/screenshots/test/browser/browser_screenshots_injection.js | Found a tab after previous test timed out: https://example.com/browser/browser/extensions/screenshots/test/browser/injection-page.html -
[task 2021-04-08T16:42:47.232Z] 16:42:47 INFO - checking window state

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5e3e273c76d
fix eslint browser/extensions/screenshots/test/browser/injection-page.html r=emalysz

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e5e3e273c76d