[wpt-sync] Sync PR 28338 - WebLocks: Remove invalid DCHECK and add some comments.
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox89 fixed)
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 28338 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/28338
Details from upstream follow.
b'Marijn Kruisselbrink <mek@chromium.org>' wrote:
WebLocks: Remove invalid DCHECK and add some comments.
It is possible for a ExecutionContext to be destroyed, and all its locks
to be released while the lock is still being set up. Remove a DCHECK
that tried to verify that this didn't happen. All the relevant code
should work correctly even if Lock::handle_ does become unbound.If the handle_ gets unbound because the ExecutionContext is destroyed
Lock might not signal LockManager that it is no longer held and thus can
be destroyed, but that is okay, as LockManager itself will clear out all
references to Lock objects when the ExecutionContext is destroyed
anyway.Bug: 1190515
Change-Id: Idbb6014cbd7f18257fdf3f7a2dffa7f7aeae75c7
Reviewed-on: https://chromium-review.googlesource.com/2783622
WPT-Export-Revision: b4a88ff2d6162817803bc92228fd5b6e35efc893
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=13b21bce646d1c096fa5dcfa922d3c0736f44bed
Assignee | ||
Comment 2•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=91a83f783254c30b71429b074affd19dbb5ce697
Assignee | ||
Comment 3•3 years ago
|
||
CI Results
Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 8 subtests
Status Summary
Firefox
OK : 1
FAIL: 8
Chrome
OK : 1
PASS: 8
Safari
OK : 1
FAIL: 8
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/web-locks/frames.tentative.https.html
Window and Frame - shared mode: FAIL (Chrome: PASS, Safari: FAIL)
Window and Frame - exclusive mode: FAIL (Chrome: PASS, Safari: FAIL)
Frame and Frame - exclusive mode: FAIL (Chrome: PASS, Safari: FAIL)
Terminated Frame with held lock: FAIL (Chrome: PASS, Safari: FAIL)
Navigated Frame with held lock: FAIL (Chrome: PASS, Safari: FAIL)
Navigated Frame with pending request: FAIL (Chrome: PASS, Safari: FAIL)
Removed Frame with pending request: FAIL (Chrome: PASS, Safari: FAIL)
Removed Frame as lock is granted: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9e97edad66ba [wpt PR 28338] - WebLocks: Remove invalid DCHECK and add some comments., a=testonly https://hg.mozilla.org/integration/autoland/rev/4a6443b711ef [wpt PR 28338] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/535519cc9848 [wpt PR 28338] - WebLocks: Remove invalid DCHECK and add some comments., a=testonly https://hg.mozilla.org/integration/autoland/rev/2a0060bec8b2 [wpt PR 28338] - Update wpt metadata, a=testonly
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/535519cc9848
https://hg.mozilla.org/mozilla-central/rev/2a0060bec8b2
Description
•