1702613 - Search bar panel is not readable in High Contrast Mode

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Petruta Horea [:phorea], Desktop QA]

Attachment: search bar panel in high contrast

Note

• Mac OSX 10.14 is not affected

Affected versions

• Fx89.0a1 2021-04-01

Affected platforms

• Windows 10 64-bit
• Ubuntu 20.04

Preconditions

• Windows: Activate OS High Contrast Theme / Ubuntu: Set OS to dark theme
• The following prefs are enabled in about:config:
  browser.proton.enabled
  browser.proton.toolbar.enabled
  browser.proton.urlbar.enabled

Steps to reproduce

1. Launch Firefox and enable the search bar.
2. Observe the search bar panel

Expected result

• Search bar panel is consistent with Proton theme

Actual result

• Search bar panel doesn't follow OS's theme and the text is not visible

Regression range

• This was introduced with bug 1695276

Comment 1

[Marco Bonardo [:mak]]

sounds like a problem with the background, probably should not be set in high contrast.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1702613 - Search bar panel is not readable in High Contrast Mode. r=harry

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4974e0fb99f0
Search bar panel is not readable in High Contrast Mode. r=harry,desktop-theme-reviewers

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4974e0fb99f0

Comment 5

[Pablo]

Attachment: image_2021-04-14_224825.png

Comment 6

[Pablo]

Hi marco, now its readable but bottom and right border are missing too in win10 64bit with high contrast.
should we log a separate bug for this?

Comment 7

[Marco Bonardo [:mak]]

(In reply to Pablo from comment #6)

Hi marco, now its readable but bottom and right border are missing too in win10 64bit with high contrast.
should we log a separate bug for this?

Yes, but it's probably a widget bug, our border is set to 1px solid white, but due to rounded border and moz-window-shadow there's some rounding for which the left border is drawn but the right is not. We may workaround that by removing the rounded border and shadow in high contrast. A lower priority bug will be good.

Comment 8

[Pablo]

thanks, i just opened https://bugzilla.mozilla.org/show_bug.cgi?id=1705814 for that.

Comment 9

[Petruta Horea [:phorea], Desktop QA]

Marking as Verified fixed for Firefox 89 beta, considering the remaining work will be handled in bug 1705814.