1702630 - [meta] Fix all DevTools tests currently failing with bfcacheInParent enabled

Status: NEW

(DevTools :: Framework, task, P3)

Description

[Alexandre Poirot [:ochameau]]

Bug 1694651 will introduce very first support for bfcacheInParent in DevTools.
A few things are still meant to be broken. A least all cases of bug 1698891's dependencies.
But we should look into all failing tests, it may help us highlight some unknown failures.
These failures would most likely also block bug 1698891.

While btcacheInParent is meant to be enabled in M7a, I don't think we should commit to fix all tests by M7a/current release. So I'd suggest triaging this bug for M8, while still having this high priority and to be investigated sooner than later. Just knowing what fails would already be a great achievement.

Comment 1

[Alexandre Poirot [:ochameau]]

Here is a try run with all the failing tests:
https://treeherder.mozilla.org/jobs?repo=try&revision=9b1d8a843333c4a83209f8de6d8a0397f4143651

Comment 2

[Alexandre Poirot [:ochameau]]

Recent try build with bfcache enabled by default:
https://treeherder.mozilla.org/jobs?repo=try&revision=ed4f4342a278376b3cdab14242b91dc3de3ca67c

Comment 3

[Marco Mucci [:MarcoM]]

Bug was reviewed today by the team during the triage meeting. Decision was taken to convert the bug into a meta.

We do not track meta bugs as part of the project - just the tagged dependencies.

Comment 4

[Chris Peterson [:cpeterson]]

Tracking for Fission MVP for our final review of Fission meta bugs before shipping.

Comment 5

[Chris Peterson [:cpeterson]]

This is a DevTools Fission (meta) bug, so adding a dt-fission whiteboard tag so the bug is categorized correctly in Fission bug queries.

Comment 6

[Chris Peterson [:cpeterson]]

Alexandre, all of the bugs blocking this meta bug are closed. Can we close this meta bug now? Or are there other DevTools tests that are still failing with bfcacheInParent enabled?

Comment 7

[Alexandre Poirot [:ochameau]]

There is still a few tests with bfcacheinparent disabled:
https://searchfox.org/mozilla-central/search?q=bfCacheInParent&path=devtools

We should first try to enable the one that honza reported as working in:
https://docs.google.com/spreadsheets/d/1fZueBqOnEplv0xCzNRwK_8qF_eCh8d3vZ4o_CpI8bdU/edit#gid=813904394

The others which were failing might have been fixed by M3 completion and the enabling of server side targets.

Comment 8

[Alexandre Poirot [:ochameau]]

After bug 1727323, most tests will run with bfcacheInParent. But not 100% of the tests, a couple are still failing because of a couple of known edgecase still known to be broken around fission.

Comment 9

[Alexandre Poirot [:ochameau]]

Here is the few tests where we still disable bfcacheInParent:

• Tests disabled because about:debugging still doesn't support target-switching and the toolbox closes on bfcache navigations (bug 1709267)
  • devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_navigate_back_forward.js
  • devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_navigate_to_url.js
• Probably fails because of bug 1700739
  • devtools/shared/commands/inspected-window/tests/browser_webextension_inspected_window.js

I'll try to bump the priority of these two first buckets as it may translate into failure that users can see.

• Tests covering both code bfcacheInParent=false && true, we can later drop bfcacheInParent=false once we stop supporting this codepath:
  • devtools/client/debugger/test/mochitest/browser_dbg-bfcache.js
  • devtools/shared/commands/target/tests/browser_target_command_bfcache.js
• Old tests which should probably be removed
  • devtools/client/framework/test/browser_target_events.js
• Intermittents to be investigated, but probably race condition in tests because of target switches:
  • devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js
  • devtools/client/framework/test/browser_toolbox_error_count_reset_on_navigation.js
  • devtools/client/webconsole/test/browser/browser_webconsole_message_categories.js
  • devtools/shared/commands/target/tests/browser_target_command_frames.js
    (All these intermittents do not reproduce with --run-until-failure, so rather hard to repro)