17027 - Eliminate dead code from layout to reduce footprint

Status: RESOLVED DUPLICATE of bug 121881

(Core :: Layout, defect, P1)

Description

[Simon Fraser [no longer active]]

Startup data show that loading the layout DLL is a significant proportion of
startup time; on Mac, this DLL is around 4Mb in size, and takes about 0.3 of a
second to load on a very fast machine. On slower machines, it could take over a
second.

There is apparently some code in layout that could be removed, or at least
#ifdeffed out. An example is the native form control frames, which could be
removed if we remove the dependency of viewer on native widgets.

So this bug should be used for dead code tracking and removal.

Comment 1

[Nisheeth Ranjan]

Kevin, would you be the right person to own the ifdefing out of native widgets
from gecko?

Comment 2

[Kevin McCluskey (gone)]

I think we need to add a define which which we will use to keep the native
widget frames and widgets in the debug build, but removes them from the release
build.

Comment 3

[Kevin McCluskey (gone)]

Moving to M14

Comment 4

[Kevin McCluskey (gone)]

Reassigning to Rod

Comment 5

[rods (gone)]

*** Bug 14819 has been marked as a duplicate of this bug. ***

Comment 6

[rods (gone)]

The extra widget classes have been removed from the windows dir.

Comment 7

[rods (gone)]

I have removed all unneeded widget classes (except those needed by the viewer) 
the viewer required classes need to be moved to the viewer directory.

moving to M15

Comment 8

[Simon Fraser [no longer active]]

rods: is your code removal XP, or just Windows? This bug should only be 
considered fixed when it's been done XP.

Comment 9

[rods (gone)]

My changes are for Windows, I figured I would reassign it to waqar or pink.

Comment 10

[rods (gone)]

nsLabel, nsButton, nsCheckButton, nsTextWidget, nsTextHelper have been removed 
from the widget factory and are not part of the viewer build (on Windows)

Now I need to move th Interfaces over and I will be able to hand the bug off.

Comment 11

[rods (gone)]

mass-move to M16

Comment 12

[rickg]

Moving out by executive order.

Comment 13

[rods (gone)]

This is mostly cleanup work that has to do with the viewer and the widget 
library setting to "future"

Comment 14

[rods (gone)]

Waqar, I am assigning this to you to fix Linux and Mac. It is fixed on Windows. 
The native widgets needs to be moved from the widget/src/<platform> directory to  
webshell/tests/viewer/<platform> directory and then the builds changed.

Check out the directory webshell/tests/viewer/windows and you will see what 
files need to be moved (approximently). Call me if you have any questions.

Comment 15

[Kevin McCluskey (gone)]

Added footprint keyword

Comment 16

[Kevin McCluskey (gone)]

Set milestone to mozilla0.8

Comment 17

[waqar]

Working on it.

Comment 18

[waqar]

Almost working, the code from widget directory has been removed but the viewer is 

having problem, I need to add some more methonds to the native widgets.

Comment 19

[Kevin McCluskey (gone)]

Taking this bug

Comment 20

[Kevin McCluskey (gone)]

Moving to Mozilla0.9.6

Comment 21

[Kevin McCluskey (gone)]

I think the solution is to re-write the viewer test app so it doesn't use any
native widgets then we can remove the remaining code from our GTK implementation
to reduce footprint.

Comment 22

[Kevin McCluskey (gone)]

Bulk moving Mozilla1.01 bugs to future-P1. I will pull from the future-P1 list
to schedule bugs for post Mozilla1.0 milestones

Comment 23

[chris hofmann]

should this be dupped against http://bugzilla.mozilla.org/show_bug.cgi?id=139911 ?

Comment 24

[Kevin McCluskey (gone)]

Probably want to keep this as a separate bug.

Once the fix for bug 139911 lands it will allow us to remove the native widgets.
 So this bug should be marked dependent on bug 139911.

Comment 25

[Boris Zbarsky [:bzbarsky]]

alecf, jkeiser, isn't this what you're sorta doing right now anyway?

Comment 26

[Wayne Mery (:wsmwk)]

(In reply to comment #24)
> Probably want to keep this as a separate bug.
> 
> Once the fix for bug 139911 lands it will allow us to remove the native widgets.
>  So this bug should be marked dependent on bug 139911.

bug 139911 was done in 2003 ... is this bug still valid?