Urlbar type icons use pre-Proton colours
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | affected |
People
(Reporter: RT, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [priority:2b][proton-address-bar])
Attachments
(1 file)
Screenshot 2021-04-02 at 18-11-18 MR1 Address Bar - UX Review - 1st Review Complete.png
- "Search with..." icons look fuzzy in dark theme
- Dark theme primary blue for bookmark icon: #00DDFF
- Dark theme icon color for "Switch to tab" icon: #FBFBFE
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
On today's nightly the star color looks ok in the dark theme, closer to the spec in light theme. As well the tab color. Not sure why they still differ slightly.
The fuzzy icons may just depend on which icon we have and hidpi, in some cases we don't have a better one, or we're waiting to be provided a better one.
NI? harry that recently landed a patch fixing these colors to check those slight differences.
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 2•3 years ago
|
||
Resolving as dupe of bug 1691993 since the newly provided icons will be hidpi
|
||
Comment 3•3 years ago
|
||
Bug 1691993 won't solve the issue of the search engine icons not being HiDPI. Marco's right that we just use the best icon we have. If a site doesn't provide a HiDPI favicon, there's not much we can do. As for the colours on the star and bookmark, that should have been solved by bug 1699226. iirc it was fixed on Nightly, but it looks like it regressed.
|
|
||
Comment 4•3 years ago
|
||
Oh, never mind. I was just using an old Nightly build on this machine :) The colours are fixed now, so there's nothing else to address in this bug.
Description
•