1702823 - Remove the reference of the function when the listener gets disconnected

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

The problem was discovered in this revision [1] where the listener was still holding the callback function that owns a strong reference to another object. As the reference of that object is still alive even if the listener had explicitly called Disconnect(), that causes a reference loop and a memory leak.

[1] https://phabricator.services.mozilla.com/D106040

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1702823 - Clear callback function after listener gets revoked. r?bryce

The callback function itself might contains a strong reference to other object, and that reference should be clear as well when the listener explicity gets revoked, which means we won't trigger the function anymore.

If the reference doen't be clear, then it's possible to cause a memory leak if the reference eventually becomes a cycle.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/081233f6b52e
Clear callback function after listener gets revoked. r=bryce

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/081233f6b52e