1702835 - Incorrect transferred min/max size with aspect-ratio

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Boris Chiou [:boris]]

It seems the if-condition for handling the transferred min/max size in nsIFrame::ComputeSize is incorrect:
example:

<div style="background: green; aspect-ratio: 1/1; height: 1000px; max-height: 100px;"></div>

This should be 100x100. We skip this case because we don't apply transferred min/max if the inline size is definite (code).

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1702835 - Min/Max size transfers should work only when inline size is not specified.

We have to apply min/max transferred size if inline size is auto or intrinsic
size keywords.

The basic principle is that sizing constraints transfer through the
aspect-ratio to the other side to preserve the aspect ratio to the extent
that they can without violating any sizes specified explicitly on that
affected axis.

Note: block-aspect-ratio-021.html tests the similar case with the non-zero
content size. However we don't have the similar tests for intrinsic size
keywords, so I add them in this patch as well.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/379285a42f12
Min/Max size transfers should work only when inline size is not specified. r=TYLin,emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28376 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/379285a42f12

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot