Closed Bug 1702842 Opened 3 years ago Closed 3 years ago

Bugzilla drop-down menu items are black on black with browser.proton.contextmenus.enabled and Dark theme

Categories

(Firefox :: Menus, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1702847

People

(Reporter: cpeterson, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

@ Gijs, I believe this is a regression from your fix for dark mode selector bug 1702626. I bisected this regression to this pushlog with bug 1702626:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=78fcad0bb24fa5188c3d1d85b3e8f30d0df13eeb&tochange=e2b5a90e8f259cd638f79efb191d3fba550f3b73

Steps to reproduce

  1. Set browser.proton.contextmenus.enabled pref = true and restart Nightly. (The browser.proton.enabled pref can be true or false; it doesn't matter for reproducing this bug.)
  2. Change your Firefox theme to Mozilla's "Dark" theme.
  3. Load a Bugzilla bug page, such as this one.
  4. Click to open a drop-down menu, such as the "Priority" menu.

Expected result

The drop-down menu items should be readable. I don't know if Proton dark mode specifies whether the menu items' background color should be white or black.

Actual result

The drop-down menu items are all black (text on black background?), except the menu item highlighted by your mouse pointer. See the attached screenshot.

Flags: needinfo?(gijskruitbosch+bugs)

Hah! interestingly I think this is bug 1702847, which I just filed and sent a fix + test for.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE

Yeah, confirmed that fixes it.

Flags: needinfo?(gijskruitbosch+bugs)
No longer blocks: proton-context-menus
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: