Make native theme drawing respect per-window ColorScheme, if widget.macos.respect-system-appearance is true
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | verified |
People
(Reporter: mstange, Assigned: mstange)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [mac:darkmode][mac:mr1])
Attachments
(6 files)
Steps to reproduce:
- Set
widget.macos.respect-system-appearance
totrue
. - Set macOS to Light Mode and Firefox to the dark Firefox theme.
- Enable high-contrast mode in the system accessibility preferences.
- Look at the buttons at the bottom of Firefox toolbar customization.
Expected results:
The controls should have a dark background so that the text on them is readable.
Actual results:
Unreadable controls with white-on-white text.
The problem is that CSS system colors now respect the Firefox theme, but -moz-default-appearance
rendering does not. The latter is what I want to fix in this bug.
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
This also removes the 10.14+ check, so that on 10.12 & 10.13 we always set
currentAppearance to aqua. This preserves RenderWithCoreUI's behavior.
Depends on D110763
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D110764
Assignee | ||
Comment 3•4 years ago
|
||
Depends on D110765
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a71a8f085944
https://hg.mozilla.org/mozilla-central/rev/e723ea00bd84
https://hg.mozilla.org/mozilla-central/rev/1ec31daa1ae0
Comment 6•4 years ago
|
||
Set release status flags based on info from the regressing bug 1700294
Updated•4 years ago
|
Comment 7•3 years ago
•
|
||
Tried reproducing the issue but had no luck in doing so. Tried with Firefox 89.0a1 (2021-04-03 and 04-01) with the OS theme set to light, pref widget.macos.respect-system-appearance to true and Firefox theme set to Dark on macOS 10.15.7 (see attachment on how it is for me).
Is there something that needs to be done to reproduce it Markus?
Comment 8•3 years ago
|
||
I talked with @csasca and I can reproduce the issue by following STR from comment 0 on macOS 11.3.1 M1 mini with Firefox 89.0a1 (20210403214826).
The issue is verified fixed with Firefox 89.0b10 (20210509185840) on the same platform. The buttons are visible after using STR from comment 0. However, I observed that about pages are no longer readable when verifying this bug. Is this a known issue? Thank you!
Assignee | ||
Comment 9•3 years ago
|
||
(In reply to Catalin Sasca, QA [:csasca] from comment #7)
Tried reproducing the issue but had no luck in doing so. Tried with Firefox 89.0a1 (2021-04-03 and 04-01) with the OS theme set to light, pref widget.macos.respect-system-appearance to true and Firefox theme set to Dark on macOS 10.15.7 (see attachment on how it is for me).
I'm not sure why it wouldn't reproduce on macOS 10.15.7 with the 2021-04-03 build. With the pref set, the text in these buttons should be white, but in your screenshot the text is black.
(In reply to Alexandru Trif, QA [:atrif] from comment #8)
Created attachment 9221106 [details]
I talked with @csasca and I can reproduce the issue by following STR from comment 0 on macOS 11.3.1 M1 mini with Firefox 89.0a1 (20210403214826).
The issue is verified fixed with Firefox 89.0b10 (20210509185840) on the same platform. The buttons are visible after using STR from comment 0.
Ok, good.
However, I observed that about pages are no longer readable when verifying this bug. Is this a known issue? Thank you!
Yes, this is bug 1710164.
Comment 10•3 years ago
|
||
Thank you, Markus! Closing this per comments above.
Description
•