Closed Bug 1702883 Opened 4 months ago Closed 4 months ago

Stop discarding NSColor alphaComponent by default

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [mac:darkmode][mac:mr1])

Attachments

(1 file)

We have a color conversion function in nsLookAndFeel.mm which discards the NSColor alpha component. That's a strange default. If we really need an opaque color, we should special-case problematic colors instead.

This fixes some transparent colors, such as the odd tree row color in dark mode (see bug 1698763).
It also seems like a more sensible default.
If we find problems with unexpectedly-transparent colors that we want to be opaque, we can fix those on a per-color basis.

Depends on D110766

Yeah, if we want opaque colors we should probably blend with white.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/6d67d9426251
Don't discard alpha in GetColorForNSColor. r=mac-reviewers,bradwerth
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.