1702980 - The Search[defaultSearchEngine] for “” link context menu option is not placed inside its own section

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: searchGoogleFor.png

Affected versions

• Firefox 89.0a1 (BuildId:20210404214218)

Affected platforms

• macOS 11
• Windows 10 64bit
• Ubuntu 18.04

Steps to reproduce

1. Launch Firefox.
2. Access the following link
3. Right click on any text link.

Expected result

• The Search [defaultSearchEngine] for “ “ option is placed in its own section as per the slide deck.

Actual result

• The Search [defaultSearchEngine] for “ “ option is not placed inside its own section.

Regression Range
This is a regression.

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e833a5f2ec97b1c48a9a8dc185ff68f4f6915d0f&tochange=1933588184c69feed359b025c9ccd6dfbd3aad28
• Potential Regressor: Bug 1701162

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Michelle,

It seems that mozregression pointed out Bug 1701162 for causing this regression.

Can you please take a look?

Thank you!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1701162

Comment 3

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1702980 - Fix "Search [defaultSearchEngine] for" contextmenu option not having its separator r?emalysz

Comment 4

[Michelle Goossens [:masterwayz]]

Whoops. My patch should fix it, at least with my testing on a local build, currently it's awaiting review.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20aa15b05faa
Fix "Search [defaultSearchEngine] for" contextmenu option not having its separator r=emalysz

Comment 6

[:Gijs (he/him)]

Would it be useful to add an automated test for the case QA reported here?

Comment 7

[Emma Malysz]

Yeah, we're going to add a test to browser_contextmenu_sendpage.js for positioning. Marking this as leave open until that lands

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/20aa15b05faa

Comment 9

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1702980 - Add test to make sure the context menu order is what we expect r?emalysz

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1300e90c6eec
Add test to make sure the context menu order is what we expect r=emalysz

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1300e90c6eec

Comment 12

[Bogdan Maris, Desktop QA]

Verified that this is fixed using latest Nightly 89.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04). Search <search engine> for "xxx" is now in its own group in between separators and has the correct placement as per design.